Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Equipped wearables not loading for peers #6025

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

dalkia
Copy link
Contributor

@dalkia dalkia commented Dec 18, 2023

What does this PR change?

Equipped wearables for peers were not loading due to inconsistencies with the Shorten urn

How to test the changes?

  1. Launch the explorer
  2. Check that peers equipped wearables load

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@github-actions github-actions bot requested a review from LucasLioyQA December 18, 2023 18:51
@dalkia dalkia force-pushed the fix/equipped-wearables-not-loading branch from cc7c0ea to 0da9cc7 Compare December 18, 2023 18:53
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Fix verified and approved. The fix was tested on Desktop and browser using Mac.

  1. Outfits are working as expected.
  2. Profile is saved correctly.
  3. Peers are being seen correctly .

fix2
fix3

@dalkia dalkia merged commit ff34e5e into dev Dec 18, 2023
11 checks passed
@dalkia dalkia deleted the fix/equipped-wearables-not-loading branch December 18, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants