Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdk7 avatar modifier area dynamic excluded ids #6038

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Jan 4, 2024

Dynamic modification of Avatar Modifier Area component excluded ids property wasn't being handled correctly.

Fixes decentraland/sdk#999 (comment)


TEST INSTRUCTIONS

  1. Open this playground link and wait for the world to load.
  2. Change the const excludedUser = 'USER-WALLET-ADDRESS-GOES-HERE' line to use a real user id (metamask wallet address) you own. For example: const excludedUser = '0x0F5D2fB29fb7d3CFeE444a200298f468908cC942'
  3. Hit the "Run" Button
  4. Enter the transparent cube area
  5. Confirm that getting close to the red cube and clicking on it (when the toggle appears) toggles your avatar being visible and invisible inside the transparent cube area
Screen.Recording.2024-01-04.at.03.28.09.mp4

@pravusjif pravusjif self-assigned this Jan 4, 2024
@pravusjif pravusjif marked this pull request as ready for review January 4, 2024 02:31
@pravusjif pravusjif requested a review from a team as a code owner January 4, 2024 02:31
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed and approved by QA. FYI, it's hard to find the toggle. Not sure if this information is relevant, but I wanted to bring it up.

Screen.Recording.2024-01-04.at.08.57.28.mov

@pravusjif pravusjif removed the request for review from a team January 4, 2024 15:53
@pravusjif pravusjif merged commit 308c4d4 into dev Jan 4, 2024
11 checks passed
@pravusjif pravusjif deleted the fix/sdk7-avatar-modifier-area-dynamic-excluded-ids branch January 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifiers area hide function doesn't respect excludeId for client
3 participants