Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set realm on signup flow #6045

Closed
wants to merge 1 commit into from
Closed

Conversation

dalkia
Copy link
Contributor

@dalkia dalkia commented Jan 8, 2024

What does this PR change?

Sets the realm on signup flow to avoid a double loading screen on scenes deployed with sdk legacy builder

How to test the changes?

  1. Enter as a new guest into enji.dcl.eth and check that you dont get a double loading screen

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Fix verified and approved.

  1. I launch DCL as a guest using the URL with the realm set as enji.dcl.eth.
  2. It accesses the world correctly without triggering the tutorial.
  3. Tested on Browser & Desktop

enji dcl eth

@dalkia
Copy link
Contributor Author

dalkia commented Jan 9, 2024

Closed as being released as hotfix at #6047

@dalkia dalkia closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants