chore: re introduce uitext wrapping #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 7SDK 6More |
Ludmilafantaniella
requested review from
Ludmilafantaniella
and removed request for
LucasLioyQA
Ludmilafantaniella
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Reviewed both URLs:
-
PLAYGROUND A: Labels behave correctly with explorer-branch=chore%2Fre-introduce-uitext-wrapping.
-
PLAYGROUND B: Confirmed expected behavior with explorer-branch=chore%2Fre-introduce-uitext-wrapping and sdk-branch=chore%2Fre-introduce-uitext-wrapping.
Also verified dialog box text wrapping on Explorer for Windows and Mac.
🟢 Approved by QA.
aixaCode
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduced ui text wrap with no-wrap as the default behavior
How to test the changes?
Use the following url: PLAYGROUND A
On the URL, note that it contains
explorer-branch=chore%2Fre-introduce-uitext-wrappingwhich means the Playground is using this branch. Then the URL follows with&code=, note there's no mention of the SDK. This would be the case where an OLD scene is loaded:Label 1, doesn't have the property => text is not wrapped
Label 2, does have the property, with the value nowrap => text is not wrapped
Label 3, does have the property, with the value wrap => text is wrapped
On the left we can see the code for the 3 labels.
Use the following url: PLAYGROUND B
On the URL, note that it contains
explorer-branch=chore%2Fre-introduce-uitext-wrappingwhich means the Playground is using this branch. Then the URL follows with?sdk-branch=chore%2Fre-introduce-uitext-wrappingwhich means the Playground is using the SDK version with the new default behavior for wrapping text. This would be the case where a new scene is created:Label 1, doesn't have the property => text is wrapped
Label 2, does have the property, with the value nowrap => text is not wrapped
Label 3, does have the property, with the value wrap => text is wrapped
On the left we can see the code for the 3 labels.
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary