Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: third party wearables v2 #6236

Merged
merged 8 commits into from
Aug 19, 2024
Merged

feat: third party wearables v2 #6236

merged 8 commits into from
Aug 19, 2024

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Jul 15, 2024

What does this PR change?

Adapts urn shortening for third party nfts.

How to test the changes?

  1. Mint a third party wearable either v1 and v2
  2. Those in sepolia network should be tested adding: &CATALYST=https://peer.decentraland.zone&NETWORK=sepolia in the url
  3. Open the backpack
  4. All wearables should be displayed in the grid, including TPW
  5. Equip TPW
  6. Close the backpack
  7. Restart the client
  8. The profile should keep the equipped TPW
  9. Add the TPW into an outfit
  10. All the outfits flow should work as expected

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@lorux0 lorux0 marked this pull request as ready for review August 8, 2024 19:04
@lorux0 lorux0 marked this pull request as draft August 8, 2024 19:13
@lorux0 lorux0 marked this pull request as ready for review August 8, 2024 19:21
@github-actions github-actions bot requested review from anicalbano and popuz August 8, 2024 19:21
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested minting third-party wearables (v1 and v2) on Sepolia network. Verified that:

  • Equipped TPW is retained after restarting the client.
  • Backpack filters work correctly.
  • Changing to non-TPW wearables saves the profile as expected.
Decentraland.-.Google.Chrome.2024-08-19.14-22-43.mp4

@lorux0 lorux0 merged commit 5092dfe into dev Aug 19, 2024
11 checks passed
@lorux0 lorux0 deleted the feat/tpw-v2 branch August 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants