Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/webserver: Download log files from UI button. #3129

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dev-warrior777
Copy link
Contributor

resolves Issue #3054

Add a button on the settings dialog [above redeem game code] to download application logs for an auth'd end user to user designated filepath.

WIP: draft for now.

@dev-warrior777
Copy link
Contributor Author

image

	- uploads to browser
	- upload preparation logic errors cause the browser to
	  show bad page load
	- does not work on webview
@dev-warrior777 dev-warrior777 marked this pull request as ready for review December 26, 2024 18:34
@dev-warrior777
Copy link
Contributor Author

I think this is done .. but I want to change the icon displayed above with bootstrap's file-arrow-down.svg.
Do we download all the bootstrap svg icons? or just a subset?

@norwnd
Copy link
Contributor

norwnd commented Dec 27, 2024

but I want to change the icon displayed above with bootstrap's file-arrow-down.svg.
Do we download all the bootstrap svg icons? or just a subset?

would appreciate if you also can download some sort of filled-circle/dot (like the one Binance uses) for this while at it - #2987 (comment)

I haven't found a well-fitting icon among existing ones that would do a great job of marking own orders (eg. right-arrow I use looks fancy at first but gets old very soon and now I feel it's best to have something simple for marking own orders)

	- Using icomoon: ico-arrowright rotated 270deg
@dev-warrior777
Copy link
Contributor Author

would appreciate if you also can download some sort of filled-circle/dot (like the one Binance uses) for this while at it - #2987 (comment)

Maybe you can have a look at the icomoon app There is a couple there in the free selection: perhaps radio-checked ea54

@norwnd
Copy link
Contributor

norwnd commented Dec 27, 2024

Maybe you can have a look at the icomoon app There is a couple there in the free selection: perhaps radio-checked ea54

yeah, probably one of these is a good choice (I'm not sure though how to import those and actually use them):

image

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 28, 2024

probably one of these is a good choice (I'm not sure though how to import those and actually use them):

Get the glyph meta-data from the icon/font provider and update font info in

these font files

image

Can look at this PR that adds a ticket icon for DCR staking.

Look at the code diff

image

@dev-warrior777
Copy link
Contributor Author

image

@norwnd
Copy link
Contributor

norwnd commented Jan 5, 2025

Can look at this PR that adds a ticket icon for DCR staking.

thanks for this suggestion,

but instead I've looked up how Binance does it and it's pure CSS, so I think something like this is better than any icon we could use:

#ownBookOrder{
    background-color: var(--text-warning);
    border-radius: 50%;
    height: 4px;
    top: 10px;
    width: 4px;
}

@dev-warrior777
Copy link
Contributor Author

Can look at this PR that adds a ticket icon for DCR staking.

thanks for this suggestion,

but instead I've looked up how Binance does it and it's pure CSS, so I think something like this is better than any icon we could use:

In the end we re-used a font icon we already had and just updated CSS to also display it rotated 270 degrees.

.ico-wide-headed-down-arrow::before {
  content: "\e919";
  display: inline-block;
  transform: rotate(270deg);
}

icons.scss

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could hide the option when not logged in, since it doesn't let you anyway then.

@dev-warrior777
Copy link
Contributor Author

You could hide the option when not logged in, since it doesn't let you anyway then.

#3129 for app version already has hidden the whole Settings dialog when unauthed. I had discussed with martonp and wanted to hide Settings before login as it is not so useful and hides the login form. Not great as someone's first impression of the product.

So this is taken care of by that PR. #3129 in bodybuilder.tmpl

	Additional:
	- I cannot seem to find a good, reliable way to upload
	  and then save a file from webserver -> webview/webkit.

	  This is a nice to have but I am spending way too much
	  time on it and what we have on this PR is already a
	  working solution for bisonw that works well every time.

	  So I consider this PR complete but will continue looking
	  for a webkit 100% reliable solution in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI suggestion: add log viewer for dexc.log
3 participants