-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/webserver: Download log files from UI button. #3129
base: master
Are you sure you want to change the base?
Conversation
- uploads to browser - upload preparation logic errors cause the browser to show bad page load - does not work on webview
I think this is done .. but I want to change the icon displayed above with bootstrap's |
would appreciate if you also can download some sort of filled-circle/dot (like the one Binance uses) for this while at it - #2987 (comment) I haven't found a well-fitting icon among existing ones that would do a great job of marking own orders (eg. right-arrow I use looks fancy at first but gets old very soon and now I feel it's best to have something simple for marking own orders) |
- Using icomoon: ico-arrowright rotated 270deg
Maybe you can have a look at the icomoon app There is a couple there in the free selection: perhaps |
yeah, probably one of these is a good choice (I'm not sure though how to import those and actually use them): |
Get the Can look at this PR that adds a |
thanks for this suggestion, but instead I've looked up how Binance does it and it's pure CSS, so I think something like this is better than any icon we could use:
|
In the end we re-used a font icon we already had and just updated CSS to also display it rotated 270 degrees.
icons.scss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could hide the option when not logged in, since it doesn't let you anyway then.
#3129 for app version already has hidden the whole Settings dialog when unauthed. I had discussed with So this is taken care of by that PR. #3129 in |
Additional: - I cannot seem to find a good, reliable way to upload and then save a file from webserver -> webview/webkit. This is a nice to have but I am spending way too much time on it and what we have on this PR is already a working solution for bisonw that works well every time. So I consider this PR complete but will continue looking for a webkit 100% reliable solution in the future.
resolves Issue #3054
Add a button on the settings dialog [above redeem game code] to download application logs for an auth'd end user to user designated filepath.
WIP: draft for now.