-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add author name to the press coverages #1015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dreacot, thanks for the submission! Overall this looks great, I've just added a couple of minor suggestions/comments.
Good to see this! Could this set authors for Press Releases too? I think they are located in src/content/press. Mind that they store metadata differently and adding authors might require patching the rendering code to consume author from Markdown's "front matter" block. |
Adding authors for Press Releases will be a bit more tricky because those are mostly unattributed at the moment. I believe the most recent ones were written by Lindsey McConaghy, and before that they would probably be from various members of the Ditto team. I don't recall who did the ones prior to Ditto. It will take some digging to go back through the years and find the relevant info, probably not a job for this pull request IMO. |
- retitle the authors of decred journals to "Decred Journal Staff" - cleanup coverage title and author name for some coverages
Lack of attribution is the "bug" I'd like to fix for Press Releases. Digging up that info is the work to do. But I agree it's better to do it separately to get this PR merged sooner. I suggest to not close #1007 with it since that issue talks about Press Releases. |
Before merging this I will edit the initial comment so that #1007 remains open. |
This PR adds the author's name to the press coverage page
Screenshots