Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[get-started] style: improve messaging on restore wallet form #3032

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

victorgcramos
Copy link
Member

This diff adds tooltips for Watch Only and Trezor, since Privacy will be removed by #3020, and adds an "Advanced Options" label.

Closes #3020

Screen Shot 2020-12-01 at 6 52 14 PM

Screen Shot 2020-12-01 at 6 52 04 PM

@jholdstock
Copy link
Member

I had thought that the "Advanced Options" would be a collapsible panel, which is hidden by default. Just adding a heading doesnt really add much value IMO.

Now that I am seeing it, I'm not sure if tooltip is correct for this. It isnt obvious that the toggle labels can be hovered over.

Perhaps we could use a light italic text, under the toggle, similar to the LN and settings tabs:

Screenshot from 2020-12-03 14-03-25
Screenshot from 2020-12-03 14-03-36

@victorgcramos
Copy link
Member Author

Nice suggestion! I really like it!

@victorgcramos
Copy link
Member Author

Screen Shot 2020-12-03 at 1 18 35 PM

@jholdstock what about now?

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good improvement. Thanks for this PR.

About watching only wallet, it is true that you can not spend any decred, but you can not do any actions, which would need signing, as a watch only wallet does not know the wallet seed.

So Also creating account, signing messages, etc. Not sure what would be a good message for that, but I'd like to make it clearer

Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the watch-only message reasonably short so we don't spam the user with information on this page. For more information, we can add a link to docs.decred.org once decred/dcrdocs#1137 is implemented.

How about this:

A watch-only wallet has limited functionality. It can only be used to view the balance and monitor transaction history. You won't be able to spend any DCR associated with this wallet.

And for the Trezor message:

Trezor is a hardware wallet. For more information, visit docs.decred.org

Linking to https://docs.decred.org/wallets/decrediton/trezor/

Screenshot from 2020-12-07 10-33-14

I'd suggest indenting the "Master pub key" field so it is aligned with the "You'll not be able..." message, or perhaps even indented slighted more than that.

And also, can we limit the width of the "Advanced Options" panel? It seems a bit too wide at the moment. max-width around 600px looks good to my eye.

@victorgcramos
Copy link
Member Author

Preview:

Screen Shot 2020-12-07 at 11 27 52 AM

Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@alexlyp alexlyp merged commit 2912ea7 into decred:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Restore Wallet page messaging
4 participants