-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[get-started] style: improve messaging on restore wallet form #3032
[get-started] style: improve messaging on restore wallet form #3032
Conversation
I had thought that the "Advanced Options" would be a collapsible panel, which is hidden by default. Just adding a heading doesnt really add much value IMO. Now that I am seeing it, I'm not sure if tooltip is correct for this. It isnt obvious that the toggle labels can be hovered over. Perhaps we could use a light italic text, under the toggle, similar to the LN and settings tabs: |
Nice suggestion! I really like it! |
@jholdstock what about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good improvement. Thanks for this PR.
About watching only wallet, it is true that you can not spend any decred, but you can not do any actions, which would need signing, as a watch only wallet does not know the wallet seed.
So Also creating account, signing messages, etc. Not sure what would be a good message for that, but I'd like to make it clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the watch-only message reasonably short so we don't spam the user with information on this page. For more information, we can add a link to docs.decred.org once decred/dcrdocs#1137 is implemented.
How about this:
A watch-only wallet has limited functionality. It can only be used to view the balance and monitor transaction history. You won't be able to spend any DCR associated with this wallet.
And for the Trezor message:
Trezor is a hardware wallet. For more information, visit docs.decred.org
Linking to https://docs.decred.org/wallets/decrediton/trezor/
I'd suggest indenting the "Master pub key" field so it is aligned with the "You'll not be able..." message, or perhaps even indented slighted more than that.
And also, can we limit the width of the "Advanced Options" panel? It seems a bit too wide at the moment. max-width around 600px looks good to my eye.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
This diff adds tooltips for Watch Only and Trezor, since Privacy will be removed by #3020, and adds an "Advanced Options" label.
Closes #3020