feat: detect piped union #5918
Merged
feat: detect piped union #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows vermin to correctly warn us if we are using the pipe union syntax. Useful to prevent issues like deephaven#5912 in the future. In addition, self-documenting fstrings will be reporteed. Both of these features are labelled as "unstable"; if vermin ever produces a false positive, we can re-consider the inclusion of these features. For example, it would have produced the following error: ``` Detecting python files.. Analyzing 247 files using 24 processes.. !2, 3.10 /home/devin/dev/deephaven/deephaven-core/py/server/deephaven/_table_reader.py union types as `X | Y` require !2, 3.10 Minimum required versions: 3.10 Incompatible versions: 2 Target versions not met: 3.8 ``` Here is the documentation for these feature flags: ``` [--feature <name>] ... Some features are disabled by default due to being unstable: fstring-self-doc - [Unstable] Detect self-documenting fstrings. Can in some cases wrongly report fstrings as self-documenting. union-types - [Unstable] Detect union types `X | Y`. Can in some cases wrongly report union types due to having to employ heuristics. ```
devinrsmith
added
ci
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
jcferretti,
JamesXNelson,
mofojed and
rcaudy
as code owners
rcaudy
approved these changes
Aug 7, 2024
jmao-denver
approved these changes
Aug 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows vermin to correctly warn us if we are using the piped union syntax. Useful to prevent issues like #5912 in the future. In addition, self-documenting fstrings will be reported. Both of these features are labelled as "unstable"; if vermin ever produces a false positive, we can re-consider the inclusion of these features.
For example, it would have produced the following error:
Here is the documentation for these feature flags: