Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cpp-client): use std::getline for reading passwords #6542

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(cpp-client): use std::getline for reading passwords #6542

merged 1 commit into from
Jan 9, 2025

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Jan 9, 2025 •
edited
Loading

Previously we were using std::cin >> s which has enough unintuitive behaviors (skipping leading whitespace, stopping at first nonleading whitespace) that we decided it was better to use std::getline

@kosak kosak self-assigned this Jan 9, 2025
@kosak kosak requested a review from jcferretti January 9, 2025 20:22
@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jan 9, 2025
@kosak kosak merged commit d9fb33e into deephaven:main Jan 9, 2025
20 of 22 checks passed
@kosak kosak deleted the kosak_getline-for-password branch January 9, 2025 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcferretti jcferretti jcferretti approved these changes

Assignees

@kosak kosak

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosak @jcferretti