feat: add thousands format for numbers (#2337)

Cherry-pick #2261 Co-authored-by: Steven Wu <[email protected]>
deephaven · Jan 9, 2025 · 8cebb63 · 8cebb63
1 parent 674ab32
commit 8cebb63
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/packages/iris-grid/src/format-context-menus/DecimalFormatContextMenu.ts b/packages/iris-grid/src/format-context-menus/DecimalFormatContextMenu.ts
@@ -37,6 +37,10 @@ class DecimalFormatContextMenu {
         format: DecimalColumnFormatter.FORMAT_BASIS_POINTS,
         group: DecimalFormatContextMenu.presetGroup,
       },
+      {
+        format: DecimalColumnFormatter.FORMAT_THOUSANDS,
+        group: DecimalFormatContextMenu.presetGroup,
+      },
       {
         format: DecimalColumnFormatter.FORMAT_MILLIONS,
         group: DecimalFormatContextMenu.presetGroup,

diff --git a/packages/iris-grid/src/format-context-menus/IntegerFormatContextMenu.ts b/packages/iris-grid/src/format-context-menus/IntegerFormatContextMenu.ts
@@ -27,6 +27,10 @@ class IntegerFormatContextMenu {
     onCustomFormatChange: (value: IntegerColumnFormat | null) => void
   ): FormatContextMenuOption[] {
     const formatItems = [
+      {
+        format: IntegerColumnFormatter.FORMAT_THOUSANDS,
+        group: IntegerFormatContextMenu.presetGroup,
+      },
       {
         format: IntegerColumnFormatter.FORMAT_MILLIONS,
         group: IntegerFormatContextMenu.presetGroup,

diff --git a/packages/jsapi-utils/src/formatters/DecimalColumnFormatter.ts b/packages/jsapi-utils/src/formatters/DecimalColumnFormatter.ts
@@ -111,6 +111,12 @@ export class DecimalColumnFormatter extends TableColumnFormatter<number> {
     10000
   );
 
+  static FORMAT_THOUSANDS = DecimalColumnFormatter.makePresetFormat(
+    'Thousands',
+    '##0.000 k',
+    0.001
+  );
+
   static FORMAT_MILLIONS = DecimalColumnFormatter.makePresetFormat(
     'Millions',
     '###,##0.000 mm',

diff --git a/packages/jsapi-utils/src/formatters/IntegerColumnFormatter.ts b/packages/jsapi-utils/src/formatters/IntegerColumnFormatter.ts
@@ -121,6 +121,12 @@ export class IntegerColumnFormatter extends TableColumnFormatter<number> {
 
   static DEFAULT_FORMAT_STRING = '###,##0';
 
+  static FORMAT_THOUSANDS = IntegerColumnFormatter.makePresetFormat(
+    'Thousands',
+    '##0.000 k',
+    0.001
+  );
+
   static FORMAT_MILLIONS = IntegerColumnFormatter.makePresetFormat(
     'Millions',
     '###,##0.000 mm',