Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Console history scroll not always sticking to bottom #2314

Merged

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 13, 2024

@mofojed mofojed requested a review from vbabich December 13, 2024 20:38
@mofojed mofojed self-assigned this Dec 13, 2024
vbabich
vbabich previously approved these changes Dec 13, 2024
@mofojed mofojed force-pushed the console-history-scroll-bottom-vplus branch from b2e9ea8 to 27d235a Compare December 13, 2024 21:05
mattrunyon and others added 2 commits December 26, 2024 13:39
@mofojed mofojed force-pushed the console-history-scroll-bottom-vplus branch from 27d235a to 7c31c8f Compare December 26, 2024 18:39
@mofojed mofojed requested a review from vbabich December 26, 2024 18:40
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.41%. Comparing base (40ef6f7) to head (7c31c8f).

Files with missing lines Patch % Lines
packages/console/src/Console.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/v0.78    #2314      +/-   ##
=================================================
- Coverage          46.41%   46.41%   -0.01%     
=================================================
  Files                676      676              
  Lines              38875    38876       +1     
  Branches            9816     9816              
=================================================
  Hits               18043    18043              
- Misses             20779    20780       +1     
  Partials              53       53              
Flag Coverage Δ
unit 46.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed enabled auto-merge (squash) December 26, 2024 18:49
@mofojed mofojed merged commit 44cbdb2 into deephaven:release/v0.78 Dec 26, 2024
9 checks passed
@mofojed mofojed deleted the console-history-scroll-bottom-vplus branch December 26, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants