feat: Deephaven UI table databar support (#2190) #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes needed for dh.ui databars - Support for extracting data in viewport columns not listed in `table.columns`. This allows us to hide the aggregation columns for databars from the user but still get their data. If a column is not in `table.columns` then it will be added to viewport data via its name instead of model index - Improved gradient rendering to be much more efficient - Fixed opacity being ignored if a gradient was used - Fixed some of the databar spacing (was 1px off center) - Modified `colorValueStyle` to have overrides so if we pass a string we don't get back `string | undefined` when we know we'll get a string - Modified `resolveCssVariablesInRecord` to always resolve CSS colors regardless of if they contain a variable
mattrunyon
approved these changes
Jan 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2340 +/- ##
==============================================
Coverage 46.71% 46.71%
==============================================
Files 689 689
Lines 38630 38623 -7
Branches 9799 9809 +10
==============================================
- Hits 18046 18043 -3
+ Misses 20574 20528 -46
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for dh.ui databars
table.columns. This allows us to hide the aggregation columns for databars from the user but still get their data. If a column is not intable.columnsthen it will be added to viewport data via its name instead of model indexcolorValueStyleto have overrides so if we pass a string we don't get backstring | undefinedwhen we know we'll get a stringresolveCssVariablesInRecordto always resolve CSS colors regardless of if they contain a variable