increase the startup timeout for the run pack #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ochko can you help us review this PR, please? |
ochko
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ECS_IMAGE_PULL_BEHAVIOR is default and the image is large, starting a console can take more time than 30 seconds. This will lead to failure to start the container. This just loosens that startup timeout.
How to check that this is working?
Only the logic has changed. The manual test riggings no longer work so need to be updated. But the test mocks the process lister and checks that the process does what it does so
go testneeds to be good enough for now. I added more modern go-modules so you can use it if you have go installed locally. Otherwise brew install go.go buildgo test