Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.76.0 #2967

Closed
wants to merge 1 commit into from
Closed

Update to Rust 1.76.0 #2967

wants to merge 1 commit into from

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Mar 4, 2024

New core will require Rust 1.74.0 so current 1.72.0 will not work.

@link2xt link2xt requested review from r10s and adbenitez March 4, 2024 19:03
New core will require Rust 1.74.0 so current 1.72.0 will not work.
@link2xt link2xt force-pushed the link2xt/update-rust-1.76 branch from 8d36479 to 21d9788 Compare March 4, 2024 19:23
Copy link

github-actions bot commented Mar 4, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member

r10s commented Mar 4, 2024

thanks a lot for pushing things forward!

however, unfortunately, i am getting some "undefined symbol" errors with this PR after running ./scripts/install-toolchains.sh: https://gist.github.com/r10s/9bfc8c9f7ecfad134b0ddfe38d5a3a25 - maybe some cache or a mac issue

@link2xt
Copy link
Contributor Author

link2xt commented Mar 5, 2024

I can try to restore 1.72 support on the core then

@link2xt
Copy link
Contributor Author

link2xt commented Mar 5, 2024

There is now core 1.136.1 that has MSRV 1.70.0

@link2xt link2xt closed this Mar 5, 2024
@link2xt
Copy link
Contributor Author

link2xt commented Mar 22, 2024

This turned out to be a problem with cc crate rather than Rust 1.76: #2972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants