refactor: Add why_cant_send_ex() capable to only ignore specified conditions #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
approved these changes
Jan 12, 2025
link2xt
reviewed
Jan 12, 2025
…ditions Before, `Chat::why_cant_send()` just returned `CantSendReason` after the first unsuccessful check allowing to handle the result and finally send the message if the condition is acceptable in which case the remaining checks are not done. This didn't result in any bugs, but to make the code more robust let's add a functional parameter to filter failed checks without early return.
iequidoo
force-pushed
the
iequidoo/why_cant_send
branch
from
2d66e5a to
3d05dfa
Compare
link2xt
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #6423. See commit messages