refactor: remove CliNpmReqResolver trait in deno_resolver
#27616
Conversation
| sys: self.sys(), | ||
| in_npm_pkg_checker: self.in_npm_pkg_checker()?.clone(), | ||
| node_resolver: self.node_resolver().await?.clone(), | ||
| npm_req_resolver: npm_resolver.clone().into_npm_req_resolver(), | ||
| npm_resolver: npm_resolver.clone().into_byonm_or_managed(), |
There was a problem hiding this comment.
This into_... is not ideal. I'll refactor the npm_resolver stuff into an enum in the future and see about pushing more of the code down to deno_resolver.
| #[class(inherit)] | ||
| #[error(transparent)] | ||
| ResolvePkgFolderFromPkgId(#[from] ResolvePkgFolderFromPkgIdError), | ||
| } |
There was a problem hiding this comment.
Moved from below so it's not inbetween the struct and its implementation.
| #[derive(Debug, thiserror::Error, deno_error::JsError)] | ||
| pub enum ResolvePkgFolderFromPkgIdError { | ||
| #[class(inherit)] | ||
| #[error("{0}")] |
There was a problem hiding this comment.
Got rid of these and replaced with error(transparent)
| match maybe_node_modules_path { | ||
| Some(node_modules_folder) => new_rc(LocalNpmPackageResolver::new( | ||
| resolution, | ||
| } |
There was a problem hiding this comment.
This struct is new. More stuff from the CLI will be moved down here in the future.
| ) -> Option<Ref<'a, V>> | ||
| where | ||
| K: std::borrow::Borrow<Q>, | ||
| { |
There was a problem hiding this comment.
Changed this because I found the crate wasn't compiling again when the sync feature isn't enabled. I think in the future we should add something to the CI to ensure all these crates compile without the sync feature and in Wasm, but atm it's not high priority.
No description provided.