Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use signal constants from libc #133

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: use signal constants from libc #133

merged 1 commit into from
Nov 28, 2024

Conversation

dsherret
Copy link
Member

This is better.

@dsherret dsherret requested a review from littledivy November 28, 2024 21:51
dsherret
dsherret commented Nov 28, 2024
View reviewed changes
src/shell/types.rs
nix::libc::SIGSTOP => SignalKind::SIGSTOP,
_ => SignalKind::Other(value),
}
#[cfg(not(unix))]
match value {
2 => SignalKind::SIGINT,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these fake values for windows are probably ok.

@dsherret dsherret changed the title fix: use signal constants from nix fix: use signal constants from libc Nov 28, 2024
@dsherret dsherret merged commit 7f0ffc9 into denoland:main Nov 28, 2024
4 checks passed
@dsherret dsherret deleted the fix_use_constants_nix branch November 28, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju