Skip to content

Commit

Permalink
chore(.github/actions): remove slack notification from RC workflow (#60)
Browse files Browse the repository at this point in the history
  • Loading branch information
Zidious authored Oct 12, 2023
1 parent be93639 commit 96267ef
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 24 deletions.
16 changes: 7 additions & 9 deletions .github/actions/create-release-candidate-v1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ A GitHub Action to create a release candidate.

## Inputs

| Name | Required | Description | Default |
| --------------------- | -------- | --------------------------------------------------------------------------------------------------- | ------- |
| `token` | Yes | A GitHub token used for octokit and GH CLI with the required permissions | NA |
| `base` | Yes | The branch the pull request will be merged into | NA |
| `head` | Yes | The branch that contains the changes the pull request is trying to merge | NA |
| Name | Required | Description | Default |
| --------------------- | -------- | ------------------------------------------------------------------------------------------ | ------- |
| `token` | Yes | A GitHub token used for octokit and GH CLI with the required permissions | NA |
| `base` | Yes | The branch the pull request will be merged into | NA |
| `head` | Yes | The branch that contains the changes the pull request is trying to merge | NA |
| `release-script-path` | Yes | The path to the script that creates the changelogs and bumps the version of the package(s) | NA |
| `slack-webhook` | Yes | The Slack webhook to send the release candidate notification to | NA |
| `version-locked` | No | Whether or not the version should be locked to axe-core | `false` |
| `docs-repo` | No | The name of the repo where the release notes live | `null` |
| `version-locked` | No | Whether or not the version should be locked to axe-core | `false` |
| `docs-repo` | No | The name of the repo where the release notes live | `null` |

## Example usage

Expand All @@ -28,7 +27,6 @@ jobs:
- uses: dequelabs/axe-api-team-public/.github/actions/create-release-candidate-v1@main
with:
token: ${{ secrets.PAT }}
slack-webhook: ${{ secrets.SLACK }}
base: 'main'
head: 'develop'
version-locked: 'false'
Expand Down
16 changes: 1 addition & 15 deletions .github/actions/create-release-candidate-v1/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ inputs:
release-script-path:
description: 'The path to the script that creates the changelogs and bumps the version of the package(s)'
required: true
slack-webhook:
description: 'The Slack webhook to send the release candidate notification to'
required: true
version-locked:
description: 'Whether or not the version should be locked to axe-core'
default: 'false'
Expand Down Expand Up @@ -175,7 +172,7 @@ runs:
# Below is everything related to this release
---
**DEPENDENCIES / BLOCKERS**
(List anything blocking this RC from continuing here)
Expand Down Expand Up @@ -220,14 +217,3 @@ runs:
issue-urls: ${{ steps.create_release_issue.outputs.issue_url }}
project-number: '103'
column-name: 'RC Created'

- name: Slack Notification
# https://github.com/rtCamp/action-slack-notify/commit/b24d75fe0e728a4bf9fc42ee217caa686d141ee8
uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7
env:
SLACK_CHANNEL: api-team-releases
SLACK_COLOR: ${{ job.status }}
SLACK_TITLE: '${{ github.event.repository.name }} v${{ steps.get_bumped_version_number.outputs.version }} QA NEEDED'
SLACK_MESSAGE: ${{ steps.create_release_issue.outputs.issue_url }}
SLACK_WEBHOOK: ${{ inputs.slack-webhook }}
MSG_MINIMAL: 'true'

0 comments on commit 96267ef

Please sign in to comment.