Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github/actions): remove slack notification from RC workflow #60

Merged
merged 1 commit into from
Oct 12, 2023
Merged

chore(.github/actions): remove slack notification from RC workflow #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/actions/create-release-candidate-v1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ A GitHub Action to create a release candidate.

## Inputs

| Name | Required | Description | Default |
| --------------------- | -------- | --------------------------------------------------------------------------------------------------- | ------- |
| `token` | Yes | A GitHub token used for octokit and GH CLI with the required permissions | NA |
| `base` | Yes | The branch the pull request will be merged into | NA |
| `head` | Yes | The branch that contains the changes the pull request is trying to merge | NA |
| Name | Required | Description | Default |
| --------------------- | -------- | ------------------------------------------------------------------------------------------ | ------- |
| `token` | Yes | A GitHub token used for octokit and GH CLI with the required permissions | NA |
| `base` | Yes | The branch the pull request will be merged into | NA |
| `head` | Yes | The branch that contains the changes the pull request is trying to merge | NA |
| `release-script-path` | Yes | The path to the script that creates the changelogs and bumps the version of the package(s) | NA |
| `slack-webhook` | Yes | The Slack webhook to send the release candidate notification to | NA |
| `version-locked` | No | Whether or not the version should be locked to axe-core | `false` |
| `docs-repo` | No | The name of the repo where the release notes live | `null` |
| `version-locked` | No | Whether or not the version should be locked to axe-core | `false` |
| `docs-repo` | No | The name of the repo where the release notes live | `null` |

## Example usage

Expand All @@ -28,7 +27,6 @@ jobs:
- uses: dequelabs/axe-api-team-public/.github/actions/create-release-candidate-v1@main
with:
token: ${{ secrets.PAT }}
slack-webhook: ${{ secrets.SLACK }}
base: 'main'
head: 'develop'
version-locked: 'false'
Expand Down
16 changes: 1 addition & 15 deletions .github/actions/create-release-candidate-v1/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ inputs:
release-script-path:
description: 'The path to the script that creates the changelogs and bumps the version of the package(s)'
required: true
slack-webhook:
description: 'The Slack webhook to send the release candidate notification to'
required: true
version-locked:
description: 'Whether or not the version should be locked to axe-core'
default: 'false'
Expand Down Expand Up @@ -175,7 +172,7 @@ runs:
# Below is everything related to this release

---

**DEPENDENCIES / BLOCKERS**

(List anything blocking this RC from continuing here)
Expand Down Expand Up @@ -220,14 +217,3 @@ runs:
issue-urls: ${{ steps.create_release_issue.outputs.issue_url }}
project-number: '103'
column-name: 'RC Created'

- name: Slack Notification
# https://github.com/rtCamp/action-slack-notify/commit/b24d75fe0e728a4bf9fc42ee217caa686d141ee8
uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7
env:
SLACK_CHANNEL: api-team-releases
SLACK_COLOR: ${{ job.status }}
SLACK_TITLE: '${{ github.event.repository.name }} v${{ steps.get_bumped_version_number.outputs.version }} QA NEEDED'
SLACK_MESSAGE: ${{ steps.create_release_issue.outputs.issue_url }}
SLACK_WEBHOOK: ${{ inputs.slack-webhook }}
MSG_MINIMAL: 'true'