Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed trimming of favorite namespaces in Config #3065

Merged

Conversation

assert-0
Copy link
Contributor

Summary

Fixed the way favorite namespaces are trimmed when validating and merging cluster configs.
Related issue: #2978

Changed

  • Namespace.merge now trims the favorite namespaces list after merging with the old Namespace object
  • fixed trimming logic so it doesn't delete elements of the list it is iterating over (anti-pattern)
  • extracted trimming logic into private helper method Namespace.trimFavNs

Added

  • Additional test case in internal/config/data/context_int_test.go for merging two oversized Namespace objects

@derailed derailed merged commit 4636a4d into derailed:master Jan 19, 2025
2 checks passed
@derailed derailed added the bug Something isn't working label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants