Skip to content

Commit

Permalink
fix: react native linking issues on ios (#273)
Browse files Browse the repository at this point in the history
## Description

This PR fixes some issues related to the linking library

<!-- Add a description of the changes that this PR introduces and the
files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is
not applicable and
please add links to any relevant follow up issues.*

- [x] included the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] provided a link to the relevant issue or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable
and please add
your handle next to the items reviewed if you only reviewed selected
items.*

- [ ] confirmed the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] confirmed all author checklist items have been addressed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced deep linking support for better app navigation.
- Improved WalletConnect functionality, including a smoother pairing
process and better handling of session proposals.

- **Bug Fixes**
- Fixed a compatibility issue with an upcoming React Native release by
adjusting `cocoapods` version constraints.
- Adjusted UI elements for better visual consistency, including icon
sizing and image display modes.

- **Refactor**
- Simplified navigation logic by removing unnecessary platform checks
and internet connectivity validation.
- Optimized action handling hooks for more efficient app state
management and user interaction flows.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Manuel <[email protected]>
  • Loading branch information
Alessandro Mazzon and manu0466 authored Mar 14, 2024
1 parent 8f25b88 commit d1a165d
Show file tree
Hide file tree
Showing 14 changed files with 514 additions and 523 deletions.
4 changes: 3 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ source 'https://rubygems.org'
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
ruby ">= 2.6.10"

gem 'cocoapods', '~> 1.13'
# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
gem 'activesupport', '>= 6.1.7.3', '< 7.1.0'
gem "fastlane"
142 changes: 67 additions & 75 deletions ios/DesmosProfileManager.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions ios/DesmosProfileManager/AppDelegate.mm
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>

#import "RNBootSplash.h"
#import <Firebase.h>
#import "RNFBMessagingModule.h"
#import <RNBranch/RNBranch.h>
#import <React/RCTLinkingManager.h>

@implementation AppDelegate

Expand All @@ -19,15 +18,16 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
//[RNBranch useTestInstance];
[RNBranch initSessionWithLaunchOptions:launchOptions isReferrable:YES];
NSURL *jsCodeLocation;

// Firebase initialization
[FIRApp configure];

return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

- (BOOL)application:(UIApplication *)app openURL:(NSURL *)url options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options {
[RNBranch application:app openURL:url options:options];
[RCTLinkingManager application:app openURL:url options:options];
return YES;
}

Expand Down
Loading

0 comments on commit d1a165d

Please sign in to comment.