Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry prompting when running with podman #870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndesKrrrrrrrrrrr
Copy link

Issue containers/podman#23055 outlines that podman doesn't search the local repository for the dynamically built image. This could be fixed by prefixing the dynamically generated image with localhost/.

Container images should be fully qualified at all times, anyways (see e.g. this RedHat blog).

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr requested a review from a team as a code owner August 12, 2024 15:52
@chrmarti
Copy link
Contributor

This should already be handled here:

'--build-arg', `BASE_IMAGE=${params.isPodman && !hasRegistryHostname(imageName) ? 'localhost/' : ''}${imageName}`, // Podman: https://github.com/microsoft/vscode-remote-release/issues/9748

Maybe the check for Podman didn't work. What output do you get from podman -v?

@zvictor
Copy link

zvictor commented Dec 10, 2024

What output do you get from podman -v?

I tried in both podman version 5.0.3 and podman version 5.3.1, and I have the issue described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants