MacOS Audio #59
MacOS Audio #59
Conversation
|
@tooxo I am in no way a go expert, and especially not a cgo expert, rather Librespot enthusiast and just trying to help/learn. I tested this branch on my M1 MacBook Air (2020) running Mac OS Sonoma 14.5. I use Zeroconf for auth and I am connecting to the go-librespot device from the Spotify client on my MacBook. Results are below it hit the not supported panic in DelayMs(). Might be way off here, but it appears we must implement this DelayMs() method using the AudioQueue API from AudioToolbox in order to calculate and return the current delay in the audio playback pipeline. I asked copilot to recommend a potential implementation of this method and it recommended calculating the delay as the difference between the current time and the time when the buffer's data is scheduled to be played. I updated this method on my local machine and was surprised to find it's now working with the updated DelayMs() function provided below. I was VERY surprised when DJ Sabrina the Teenage DJ's "Next to Me" actually starting playing on my airpods lol FYI volume control from Spotify client is not working. I hope this helps, Till. Relevant Code below - line 257 func (out *output) DelayMs() (int64, error) {
panic("not supported")
}Proposed Method from copilot: func (out *output) DelayMs() (int64, error) {
var queueTime C.AudioTimeStamp
err := C.AudioQueueGetCurrentTime(out.audioQueue, nil, &queueTime, nil)
if err != 0 {
return 0, out.alsaError("AudioQueueGetCurrentTime", err)
}
// Convert to milliseconds
delay := int64((queueTime.mSampleTime / C.Float64(out.sampleRate)) * 1000)
return delay, nil
}Environment: Command Line Output: |
Thank you very much for your feedback, I implemented the delay and volume now, so i hope it at least works a little bit more flawless now. |
|
@tooxo this is working perfectly! no DelayMs() panic anymore and volume control works as well. I see you used the lower level AudioObjectGetPropertyData instead of AudioQueue to query the device's inherent latency, nice. Please let me know if you need any more help testing. |
If you want to, testing it for longer periods at a time would probably find some more smaller issues, but what I would rather need is some advice on how to test cgo code, especially searching for memory leaks and undefined behaviour. |
I can definitely test it for longer periods of time! re: searching for memory leaks, it looks like we might be able to use valgrind for this? Debugging Cgo memory leaks |
Yes, I used valgrind before, but the problem is I only have a M1 mac, where there is no supported version unfortunately |
|
@tooxo What do you think is the state of this PR? |
|
Used this PR to get a dev environment setup on my Macbook, but made some changes like to volume adjustment, buffer allocation, buffering logic in general (no more ring buffer). Will be testing: master...stronk-dev:go-librespot:feature/AudioToolbox |
There have been some refactors of the audio part since this PR was originally created so it's very likely that this was outdated. If you feel like you have something working feel free to open a new PR, this one may be stale. |
This is a very rudimentary proof of concept, using macos audio-toolbox.
To make this remotely ready for production, I would need some help from someone who knows go (especially cgo) better than me.