misc: Add Omnitrace and Omniperf to Dockerfile.amd #2032
Conversation
docker/Dockerfile.amd
Outdated
| mv omnitrace-installer.sh /opt/omnitrace && \ | ||
| cd /opt/omnitrace && \ | ||
| ./omnitrace-installer.sh --skip-license && \ | ||
| cd - |
There was a problem hiding this comment.
no needed automatically exits back to base dir at the ned of RUN
There was a problem hiding this comment.
Can be simplified to one line with just
RUN ./omnitrace-1.7.3-ubuntu-20.04-ROCm-50100-PAPI-OMPT-Python3.sh --prefix=/opt/omnitrace --exclude-subdir --skip-license && rm omnitrace-1.7.3-ubuntu-20.04-ROCm-50100-PAPI-OMPT-Python3.sh
FabioLuporini
changed the title
FabioLuporini
force-pushed
the
amd-omnitrace
branch
from
0a3aa13 to
efa64d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2032 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 214 214
Lines 37327 37327
Branches 5627 5627
=======================================
Hits 32794 32794
Misses 4007 4007
Partials 526 526 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FabioLuporini
force-pushed
the
amd-omnitrace
branch
from
efa64d6 to
63813a7
Compare
There was a problem hiding this comment.
@mloubout one question
I had to switch from
ENV OMNIPERF_DIR=/opt/omniperf
to
ENV OMNIPERF_DIR=/app/omniperf
because for some reason the package wouldn't appear in opt. Any idea what the cause might be? 😮
|
@mloubout I've pushed some edits, but I still have to test this: ROCm/omnitrace#217 (comment) |
|
That's weird for Did you look at the log? May be just that need to create the directory first |
|
log was fine AFAICT Also, this env var Doesn't persist in the container. LIterally, it's not there. Any idea @mloubout ? |
FabioLuporini
force-pushed
the
amd-omnitrace
branch
from
7456365 to
d4e9dc3
Compare
|
I pushed several edits. Could you take another look @mloubout ? |
| # This Dockerfile contains AMD compilers | ||
| ############################################################## | ||
| #################################################################################### | ||
| # This Dockerfile contains the AMD ROCm SDK as well as other useful tools for Devito |
There was a problem hiding this comment.
as well as AMD profiling tools (Omnitrace, Omniperf) useful to Devito... or something like this...
| @@ -45,11 +63,52 @@ ENV PATH=${PATH}:/opt/openmpi/bin:$AOMP/bin | |||
| ENV LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:/opt/openmpi/lib:$AOMP/lib | |||
| ENV OMPI_CC=$AOMP/bin/clang | |||
|
|
|||
| # Devito env | |||
| # Install Omnitrace, an AMDResearch profiling tool akin to Nvidia's Nsight-systems | |||
There was a problem hiding this comment.
I would drop akin to....
There was a problem hiding this comment.
Omniperf is very similar to Nsight-Compute but the capabilities of Omnitrace far exceed the capabilities of Nsight-Systems. Intel's VTune is closer analogue.
| ./omnitrace-1.7.3-ubuntu-20.04-ROCm-50100-PAPI-OMPT-Python3.sh --prefix=${OMNITRACE_DIR} --exclude-subdir --skip-license && \ | ||
| rm omnitrace-1.7.3-ubuntu-20.04-ROCm-50100-PAPI-OMPT-Python3.sh | ||
|
|
||
| # Install Omniperf, an AMDResearch profiling tool akin to Nvidia's Nsight-compute |
|
|
||
| ENV DEVITO_ARCH="hip" | ||
| ENV DEVITO_PLATFORM="amdgpuX" | ||
| ENV DEVITO_LANGUAGE="hip" |
There was a problem hiding this comment.
Should this be added to the cron CI?
Also maybe a line in the Readme that it's an option now
There was a problem hiding this comment.
We can and should add it to the cron jobs, I agree.
We shouldn't isntead write anything in the README until support is complete. This is to be regarded as a dev utility for now
|
This should be gtg right |
|
I'm waiting for this ROCm/rocprofiler-compute#45 (comment) I'll tag u in that issue so that you can track progress |
|
Status on this? Still wanted? |
|
@mloubout yes, but some story as Dockerfile.amd -- I want to be able to pull in from something they maintain , especially since the project is young But we definitely want the AMD profilers in |
|
Just checked -- They have added something recently, but ... https://github.com/AMDResearch/omniperf/blob/main/docker/ubuntu20.04/Dockerfile an amdgpu package? unsure.. |
|
So what's the plan for this? |
|
HOnestly don't know yet, I have to look at their latest installation instructions to see if it got any simpler the way it is at the moment is too painful and I wouldn't want to maintain it That said, having the AMD profiler around in our Docker image would be quite useful... |
wget https://github.com/AMDResearch/omnitrace/releases/latest/download/omnitrace-install.py
python3 ./omnitrace-install.py --prefix /opt/omnitrace/rocm-5.4 --rocm 5.4Omnitrace installation is quite straightforward |
No description provided.