fix: Notification QA fixes #2349
Conversation
…rd into feat/rb-compare-sync
feat: add vertical-divider class for improved layout separation
shivani170
requested review from
vikramdevtron and
vivek-devtron
as code owners
feat: add useBuildXDriver for build infra
fix: re-generate the encoded url for external links
| @@ -53,24 +52,22 @@ const SESConfigModal = ({ | |||
|
|
|||
| const [form, setForm] = useState<SESFormType>(getSESDefaultConfiguration(shouldBeDefault)) | |||
| const [isFormValid, setFormValid] = useState(DefaultSESValidations) | |||
|
|
|||
| const awsRegionListParsed = awsRegionList | |||
There was a problem hiding this comment.
Instead of removing this we should move it on line no 43 and use it in the component
| !!authPassword && | ||
| !!fromEmail && | ||
| getFormValidated(isFormValid, fromEmail) | ||
| validateKeyValueConfig(ConfigurationFieldKeys.CONFIG_NAME, configName).isValid && |
There was a problem hiding this comment.
Why are again validationg the same. we should use the value from line no 94 setter
| webhookUrl: validateKeyValueConfig(ConfigurationFieldKeys.WEBHOOK_URL, webhookUrl), | ||
| projectId: validateKeyValueConfig(ConfigurationFieldKeys.PROJECT_ID, selectedProject?.value ?? ''), | ||
| })) | ||
| return ( |
There was a problem hiding this comment.
Instead of calling the method again we should reuse the values from line no 90
| webhookUrl: validateKeyValueConfig(ConfigurationFieldKeys.WEBHOOK_URL, webhookUrl), | ||
| payload: validatePayloadField(payload), | ||
| }) | ||
| setFormValid({ |
There was a problem hiding this comment.
Please remove the duplicated code
| webhookUrl: validateKeyValueConfig(ConfigurationFieldKeys.WEBHOOK_URL, webhookUrl), | ||
| payload: validatePayloadField(payload), | ||
| }) | ||
| return ( |
There was a problem hiding this comment.
Why are we calling the sam emthod again and again
| if (element.key != '') { | ||
| headerObj[element.key] = element.value | ||
| } | ||
| }) | ||
|
|
||
| const payload = { |
There was a problem hiding this comment.
This payload should be created from the form itself
| @@ -358,3 +353,8 @@ export const renderErrorToast = () => | |||
| variant: ToastVariantType.error, | |||
| description: 'Some required fields are missing or Invalid', | |||
| }) | |||
|
|
|||
| export const getAwsRegionListParsed = (awsRegionList) => | |||
There was a problem hiding this comment.
This should be removed
There was a problem hiding this comment.
We are using this util in other component
There was a problem hiding this comment.
Moved this util to the component.
…e error handling in dry run
refactor: ConfigMapSecret -update form submission handlers and improve error handling in dry run
feat: bifurcate image cards in imageScan codeScan and manifestScan
…rd into fix/security-issues
fix: global security issues
feat: add vertical-divider class for improved layout separation
|
Description
fix: Notification QA fixes
Fixes # (issue)
Type of change
Checklist: