Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTING: gRPC support add #4496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

TESTING: gRPC support add #4496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e5ee97
Adds support for gRPC in health probes
tayalrishabh96 Jan 3, 2024
9344a60
TESTING: support for gRPC in health probes
tayalrishabh96 Jan 3, 2024
55a5c84
TESTING: removes reference_chart_4-19-0
tayalrishabh96 Jan 3, 2024
5947953
added grpc support in sts and deployment chart
rupinSec Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# Deployment Chart - v4.18.0
# Deployment Chart - v4.19.0

## 1. Yaml File -

Expand Down Expand Up @@ -73,6 +73,9 @@ LivenessProbe:
value: abc
scheme: ""
tcp: true
grpc:
port: 8080
service: ""
```

| Key | Description |
Expand All @@ -86,7 +89,7 @@ LivenessProbe:
| `httpHeaders` | Custom headers to set in the request. HTTP allows repeated headers,You can override the default headers by defining .httpHeaders for the probe. |
| `scheme` | Scheme to use for connecting to the host (HTTP or HTTPS). Defaults to HTTP.
| `tcp` | The kubelet will attempt to open a socket to your container on the specified port. If it can establish a connection, the container is considered healthy. |

| `grpc` | GRPC specifies an action involving a GRPC port. Port is a required field if using gRPC service for health probes. Number must be in the range 1 to 65535. Service (optional) is the name of the service to place in the gRPC HealthCheckRequest. |

### MaxUnavailable

Expand Down Expand Up @@ -128,6 +131,9 @@ ReadinessProbe:
value: abc
scheme: ""
tcp: true
grpc:
port: 8080
service: ""
```

| Key | Description |
Expand All @@ -141,6 +147,7 @@ ReadinessProbe:
| `httpHeaders` | Custom headers to set in the request. HTTP allows repeated headers,You can override the default headers by defining .httpHeaders for the probe. |
| `scheme` | Scheme to use for connecting to the host (HTTP or HTTPS). Defaults to HTTP.
| `tcp` | The kubelet will attempt to open a socket to your container on the specified port. If it can establish a connection, the container is considered healthy. |
| `grpc` | GRPC specifies an action involving a GRPC port. Port is a required field if using gRPC service for health probes. Number must be in the range 1 to 65535. Service (optional) is the name of the service to place in the gRPC HealthCheckRequest. |

### Pod Disruption Budget

Expand Down
3 changes: 3 additions & 0 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/app-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ LivenessProbe:
successThreshold: 1
timeoutSeconds: 5
failureThreshold: 3
grpc: {}

ReadinessProbe:
Path: ""
Expand All @@ -94,6 +95,7 @@ ReadinessProbe:
successThreshold: 1
timeoutSeconds: 5
failureThreshold: 3
grpc: {}

StartupProbe:
Path: ""
Expand All @@ -106,6 +108,7 @@ StartupProbe:
httpHeaders: []
command: []
tcp: false
grpc: {}

ingress:
enabled: false
Expand Down
18 changes: 15 additions & 3 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ spec:
{{- end }}
{{- end }}

{{- if or $.Values.LivenessProbe.Path $.Values.LivenessProbe.command $.Values.LivenessProbe.tcp }}
{{- if or $.Values.LivenessProbe.Path $.Values.LivenessProbe.command $.Values.LivenessProbe.tcp $.Values.LivenessProbe.grpc }}
livenessProbe:
{{- if $.Values.LivenessProbe.Path }}
httpGet:
Expand Down Expand Up @@ -370,8 +370,12 @@ spec:
successThreshold: {{ $.Values.LivenessProbe.successThreshold }}
timeoutSeconds: {{ $.Values.LivenessProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.LivenessProbe.failureThreshold }}
{{- if $.Values.LivenessProbe.grpc }}
grpc:
{{ toYaml .Values.LivenessProbe.grpc | indent 14 }}
{{- end }}
{{- end }}
{{- if or $.Values.ReadinessProbe.Path $.Values.ReadinessProbe.command $.Values.ReadinessProbe.tcp }}
{{- if or $.Values.ReadinessProbe.Path $.Values.ReadinessProbe.command $.Values.ReadinessProbe.tcp $.Values.ReadinessProbe.grpc }}
readinessProbe:
{{- if $.Values.ReadinessProbe.Path }}
httpGet:
Expand Down Expand Up @@ -399,10 +403,14 @@ spec:
successThreshold: {{ $.Values.ReadinessProbe.successThreshold }}
timeoutSeconds: {{ $.Values.ReadinessProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.ReadinessProbe.failureThreshold }}
{{- if $.Values.ReadinessProbe.grpc }}
grpc:
{{ toYaml .Values.ReadinessProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
resources:
{{ toYaml $.Values.resources | trim | indent 12 }}
{{- if or $.Values.StartupProbe.Path $.Values.StartupProbe.command $.Values.StartupProbe.tcp }}
{{- if or $.Values.StartupProbe.Path $.Values.StartupProbe.command $.Values.StartupProbe.tcp $.Values.StartupProbe.grpc }}
startupProbe:
{{- if $.Values.StartupProbe.Path }}
httpGet:
Expand Down Expand Up @@ -430,6 +438,10 @@ spec:
successThreshold: {{ $.Values.StartupProbe.successThreshold }}
timeoutSeconds: {{ $.Values.StartupProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.StartupProbe.failureThreshold }}
{{- if $.Values.StartupProbe.grpc }}
grpc:
{{ toYaml .Values.StartupProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
volumeMounts:
{{- with .Values.volumeMounts }}
Expand Down
3 changes: 3 additions & 0 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ LivenessProbe:
httpHeaders: []
# - name: Custom-Header
# value: abc
grpc: {}

ReadinessProbe:
Path: /
Expand All @@ -352,6 +353,7 @@ ReadinessProbe:
httpHeaders: []
# - name: Custom-Header
# value: abc
grpc: {}

StartupProbe:
Path: ""
Expand All @@ -364,6 +366,7 @@ StartupProbe:
httpHeaders: []
command: []
tcp: false
grpc: {}

prometheus:
release: monitoring
Expand Down
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_4-18-0/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
name: reference-chart_4-18-0
version: 4.18.0
name: reference-chart_4-19-0
version: 4.19.0
10 changes: 9 additions & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_4-18-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# Rollout Deployment Chart - v4.18
# Rollout Deployment Chart - v4.19

## 1. Yaml File -

Expand Down Expand Up @@ -74,6 +74,9 @@ LivenessProbe:
value: abc
scheme: ""
tcp: true
grpc:
port: 8000
service: ""
```

| Key | Description |
Expand All @@ -87,6 +90,7 @@ LivenessProbe:
| `httpHeaders` | Custom headers to set in the request. HTTP allows repeated headers,You can override the default headers by defining .httpHeaders for the probe. |
| `scheme` | Scheme to use for connecting to the host (HTTP or HTTPS). Defaults to HTTP.
| `tcp` | The kubelet will attempt to open a socket to your container on the specified port. If it can establish a connection, the container is considered healthy. |
| `grpc` | GRPC specifies an action involving a GRPC port. Port is a required field if using gRPC service for health probes. Number must be in the range 1 to 65535. Service (optional) is the name of the service to place in the gRPC HealthCheckRequest. |


### MaxUnavailable
Expand Down Expand Up @@ -129,6 +133,9 @@ ReadinessProbe:
value: abc
scheme: ""
tcp: true
grpc:
port: 8000
service: ""
```

| Key | Description |
Expand All @@ -142,6 +149,7 @@ ReadinessProbe:
| `httpHeaders` | Custom headers to set in the request. HTTP allows repeated headers,You can override the default headers by defining .httpHeaders for the probe. |
| `scheme` | Scheme to use for connecting to the host (HTTP or HTTPS). Defaults to HTTP.
| `tcp` | The kubelet will attempt to open a socket to your container on the specified port. If it can establish a connection, the container is considered healthy. |
| `grpc` | GRPC specifies an action involving a GRPC port. Port is a required field if using gRPC service for health probes. Number must be in the range 1 to 65535. Service (optional) is the name of the service to place in the gRPC HealthCheckRequest. |

### Pod Disruption Budget

Expand Down
3 changes: 3 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-18-0/app-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ LivenessProbe:
successThreshold: 1
timeoutSeconds: 5
failureThreshold: 3
grpc: {}

ReadinessProbe:
Path: ""
Expand All @@ -94,6 +95,7 @@ ReadinessProbe:
successThreshold: 1
timeoutSeconds: 5
failureThreshold: 3
grpc: {}

StartupProbe:
Path: ""
Expand All @@ -106,6 +108,7 @@ StartupProbe:
httpHeaders: []
command: []
tcp: false
grpc: {}

ingress:
enabled: false
Expand Down
20 changes: 16 additions & 4 deletions scripts/devtron-reference-helm-charts/reference-chart_4-18-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ spec:
{{- end }}
{{- end }}

{{- if or $.Values.LivenessProbe.Path $.Values.LivenessProbe.command $.Values.LivenessProbe.tcp }}
{{- if or $.Values.LivenessProbe.Path $.Values.LivenessProbe.command $.Values.LivenessProbe.tcp $.Values.LivenessProbe.grpc }}
livenessProbe:
{{- if $.Values.LivenessProbe.Path }}
httpGet:
Expand All @@ -357,7 +357,7 @@ spec:
value: {{.value}}
{{- end}}
{{- end }}
{{- end }}
{{- end }}
{{- if $.Values.LivenessProbe.command }}
exec:
command:
Expand All @@ -372,8 +372,12 @@ spec:
successThreshold: {{ $.Values.LivenessProbe.successThreshold }}
timeoutSeconds: {{ $.Values.LivenessProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.LivenessProbe.failureThreshold }}
{{- if $.Values.LivenessProbe.grpc }}
grpc:
{{ toYaml .Values.LivenessProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
{{- if or $.Values.ReadinessProbe.Path $.Values.ReadinessProbe.command $.Values.ReadinessProbe.tcp }}
{{- if or $.Values.ReadinessProbe.Path $.Values.ReadinessProbe.command $.Values.ReadinessProbe.tcp $.Values.ReadinessProbe.grpc }}
readinessProbe:
{{- if $.Values.ReadinessProbe.Path }}
httpGet:
Expand Down Expand Up @@ -401,10 +405,14 @@ spec:
successThreshold: {{ $.Values.ReadinessProbe.successThreshold }}
timeoutSeconds: {{ $.Values.ReadinessProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.ReadinessProbe.failureThreshold }}
{{- if $.Values.ReadinessProbe.grpc }}
grpc:
{{ toYaml .Values.ReadinessProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
resources:
{{ toYaml $.Values.resources | trim | indent 12 }}
{{- if or $.Values.StartupProbe.Path $.Values.StartupProbe.command $.Values.StartupProbe.tcp }}
{{- if or $.Values.StartupProbe.Path $.Values.StartupProbe.command $.Values.StartupProbe.tcp $.Values.StartupProbe.grpc }}
startupProbe:
{{- if $.Values.StartupProbe.Path }}
httpGet:
Expand Down Expand Up @@ -432,6 +440,10 @@ spec:
successThreshold: {{ $.Values.StartupProbe.successThreshold }}
timeoutSeconds: {{ $.Values.StartupProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.StartupProbe.failureThreshold }}
{{- if $.Values.StartupProbe.grpc }}
grpc:
{{ toYaml .Values.StartupProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
volumeMounts:
{{- with .Values.volumeMounts }}
Expand Down
9 changes: 9 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_4-18-0/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ LivenessProbe:
httpHeaders: []
# - name: Custom-Header
# value: abc
grpc: {}
# port: 8000 # Port number of the gRPC service. Number must be in the range 1 to 65535.
# service: "" # Service is the name of the service to place in the gRPC HealthCheckRequest

ReadinessProbe:
Path: /
Expand All @@ -169,6 +172,9 @@ ReadinessProbe:
httpHeaders: []
# - name: Custom-Header
# value: abc
grpc: {}
# port: 8000 # Port number of the gRPC service. Number must be in the range 1 to 65535.
# service: "" # Service is the name of the service to place in the gRPC HealthCheckRequest

StartupProbe:
Path: ""
Expand All @@ -181,6 +187,9 @@ StartupProbe:
httpHeaders: []
command: []
tcp: false
grpc: {}
# port: 8000 # Port number of the gRPC service. Number must be in the range 1 to 65535.
# service: "" # Service is the name of the service to place in the gRPC HealthCheckRequest

prometheus:
release: monitoring
Expand Down
11 changes: 10 additions & 1 deletion scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# StatefulSet Chart 1.0.0
# StatefulSet Chart 1.1.0

## 1. Yaml File -

Expand Down Expand Up @@ -191,6 +191,9 @@ LivenessProbe:
value: abc
scheme: ""
tcp: true
grpc:
port: 8080
service: ""
```

| Key | Description |
Expand All @@ -204,6 +207,8 @@ LivenessProbe:
| `httpHeaders` | Custom headers to set in the request. HTTP allows repeated headers,You can override the default headers by defining .httpHeaders for the probe. |
| `scheme` | Scheme to use for connecting to the host (HTTP or HTTPS). Defaults to HTTP.
| `tcp` | The kubelet will attempt to open a socket to your container on the specified port. If it can establish a connection, the container is considered healthy. |
| `grpc` | GRPC specifies an action involving a GRPC port. Port is a required field if using gRPC service for health probes. Number must be in the range 1 to 65535. Service (optional) is the name of the service to place in the gRPC HealthCheckRequest. |



### MaxUnavailable
Expand Down Expand Up @@ -246,6 +251,9 @@ ReadinessProbe:
value: abc
scheme: ""
tcp: true
grpc:
port: 8000
service: ""
```

| Key | Description |
Expand All @@ -259,6 +267,7 @@ ReadinessProbe:
| `httpHeaders` | Custom headers to set in the request. HTTP allows repeated headers,You can override the default headers by defining .httpHeaders for the probe. |
| `scheme` | Scheme to use for connecting to the host (HTTP or HTTPS). Defaults to HTTP.
| `tcp` | The kubelet will attempt to open a socket to your container on the specified port. If it can establish a connection, the container is considered healthy. |
| `grpc` | GRPC specifies an action involving a GRPC port. Port is a required field if using gRPC service for health probes. Number must be in the range 1 to 65535. Service (optional) is the name of the service to place in the gRPC HealthCheckRequest. |

### Ambassador Mappings

Expand Down
2 changes: 2 additions & 0 deletions scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/app-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ LivenessProbe:
successThreshold: 1
timeoutSeconds: 5
failureThreshold: 3
grpc: {}

ReadinessProbe:
Path: ""
Expand All @@ -126,6 +127,7 @@ ReadinessProbe:
successThreshold: 1
timeoutSeconds: 5
failureThreshold: 3
grpc: {}

ingress:
enabled: false
Expand Down
12 changes: 10 additions & 2 deletions scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ spec:
{{- end }}
{{- end }}

{{- if or $.Values.LivenessProbe.Path $.Values.LivenessProbe.command $.Values.LivenessProbe.tcp }}
{{- if or $.Values.LivenessProbe.Path $.Values.LivenessProbe.command $.Values.LivenessProbe.tcp $.Values.LivenessProbe.grpc }}
livenessProbe:
{{- if $.Values.LivenessProbe.Path }}
httpGet:
Expand Down Expand Up @@ -365,8 +365,12 @@ spec:
successThreshold: {{ $.Values.LivenessProbe.successThreshold }}
timeoutSeconds: {{ $.Values.LivenessProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.LivenessProbe.failureThreshold }}
{{- if $.Values.LivenessProbe.grpc }}
grpc:
{{ toYaml .Values.LivenessProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
{{- if or $.Values.ReadinessProbe.Path $.Values.ReadinessProbe.command $.Values.ReadinessProbe.tcp }}
{{- if or $.Values.ReadinessProbe.Path $.Values.ReadinessProbe.command $.Values.ReadinessProbe.tcp $.Values.LivenessProbe.grpc }}
readinessProbe:
{{- if $.Values.ReadinessProbe.Path }}
httpGet:
Expand Down Expand Up @@ -394,6 +398,10 @@ spec:
successThreshold: {{ $.Values.ReadinessProbe.successThreshold }}
timeoutSeconds: {{ $.Values.ReadinessProbe.timeoutSeconds }}
failureThreshold: {{ $.Values.ReadinessProbe.failureThreshold }}
{{- if $.Values.LivenessProbe.grpc }}
grpc:
{{ toYaml .Values.LivenessProbe.grpc | indent 14 }}
{{- end}}
{{- end }}
resources:
{{ toYaml $.Values.resources | trim | indent 12 }}
Expand Down
Loading
Loading