fix:duplicate workflow name fixed #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laeeqdev
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
Laeeqdev
changed the title
github-actions
bot
added
PR:Issue-verification-failed
and removed
PR:Ready-to-Review
labels
Laeeqdev
changed the title
prakash100198
requested changes
Apr 1, 2024
…o duplicate-workflow-name-fix
prakash100198
requested changes
Apr 2, 2024
prakash100198
previously approved these changes
Apr 2, 2024
* Modifying pager duty python script * Updated CODEOWNERS --------- Co-authored-by: Prakarsh <[email protected]>
…ion _revised (#4836) * Revised the api for handelling the overview git commits part using CiArtifact table only * Removed unnecessary comments * optimized the loop and intialization * used maps instead of slices * removed unused comments * modified the GetUniqueArtifactIds * Removed error from util function * renamed the function as generateArtifactIDCommitMap
* MailMaster Plugin v1.0 * Update 232_mailmaster.up.sql Updated Variable Names * Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql * Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql * 233_mailmaster.up.sql --------- Co-authored-by: Prakarsh <[email protected]>
Co-authored-by: Vikram <[email protected]>
…ocessor service (#4875)
* dependabot version upgrade * dependabot version upgrade * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * argo assets deletion reverted
* change sync * vars * refactor * fix: use JoinCookie method (#4892) * sql file merged --------- Co-authored-by: adi6859 <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]>
* lower case rbac objects * lower case * lower
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <[email protected]> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <[email protected]> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <[email protected]> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <[email protected]> --------- Co-authored-by: kartik-579 <[email protected]> Co-authored-by: Nishant <[email protected]> Co-authored-by: nishant <[email protected]> Co-authored-by: Shashwat Dadhich <[email protected]>
* fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: remove digest column length update
* migration support for notification db changes * updated query with internal flag
* Added the Devtron CI Trigger Plugin * Rename 235_devtron_ci_trigger_plugin.down.sql to 236_devtron_ci_trigger_plugin.down.sql * Rename 235_devtron_ci_trigger_plugin.up.sql to 236_devtron_ci_trigger_plugin.up.sql * Rename 236_devtron_ci_trigger_plugin.down.sql to 237_devtron_ci_trigger_plugin.down.sql * Rename 236_devtron_ci_trigger_plugin.up.sql to 237_devtron_ci_trigger_plugin.up.sql
|
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
prakash100198
approved these changes
Apr 9, 2024
kripanshdevtron
approved these changes
Apr 9, 2024
prakash100198
approved these changes
Apr 9, 2024
komalreddy3
pushed a commit
that referenced
this pull request
May 28, 2024
* duplicate workflow name bug resolved * refactored code * completed dev testing and code * PR code review comments resolved * resolved PR code review comments * resolved PR code review comments final * misc: Refactoring Pagerduty Issue Calculator script (#4856) * Modifying pager duty python script * Updated CODEOWNERS --------- Co-authored-by: Prakarsh <[email protected]> * feat: Add support for git hash in the app and app group overview section _revised (#4836) * Revised the api for handelling the overview git commits part using CiArtifact table only * Removed unnecessary comments * optimized the loop and intialization * used maps instead of slices * removed unused comments * modified the GetUniqueArtifactIds * Removed error from util function * renamed the function as generateArtifactIDCommitMap * feat:MailMaster Plugin v1.0 (#4825) * MailMaster Plugin v1.0 * Update 232_mailmaster.up.sql Updated Variable Names * Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql * Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql * 233_mailmaster.up.sql --------- Co-authored-by: Prakarsh <[email protected]> * return nil,err on git material fetch error (#4857) * removed code for gitops repo migration in devtron apps (#4838) Co-authored-by: Vikram <[email protected]> * fix: update argo app repo url in patch (#4876) * fix: injected app-serveice dependency into DeployedApplicationEventProcessor service (#4875) * fix: depandabot version upgrade (#4792) * dependabot version upgrade * dependabot version upgrade * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * argo assets deletion reverted * syncing specifig chart (#4631) * fix: use JoinCookie method (#4892) * chore: Resource mapping refactoring (#4813) * change sync * vars * refactor * fix: use JoinCookie method (#4892) * sql file merged --------- Co-authored-by: adi6859 <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> * fix: rbac fix in case of project in upper case (#4840) * lower case rbac objects * lower case * lower * chore: App Store refactoring v4 (#4647) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <[email protected]> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <[email protected]> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <[email protected]> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <[email protected]> --------- Co-authored-by: kartik-579 <[email protected]> Co-authored-by: Nishant <[email protected]> Co-authored-by: nishant <[email protected]> Co-authored-by: Shashwat Dadhich <[email protected]> * fix: deprecate latest in app store app version (#4896) * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: remove digest column length update * chore: migration support for notification db changes (#4906) * migration support for notification db changes * updated query with internal flag * feat: Added the Devtron CI Trigger Plugin (#4902) (#4908) * Added the Devtron CI Trigger Plugin * Rename 235_devtron_ci_trigger_plugin.down.sql to 236_devtron_ci_trigger_plugin.down.sql * Rename 235_devtron_ci_trigger_plugin.up.sql to 236_devtron_ci_trigger_plugin.up.sql * Rename 236_devtron_ci_trigger_plugin.down.sql to 237_devtron_ci_trigger_plugin.down.sql * Rename 236_devtron_ci_trigger_plugin.up.sql to 237_devtron_ci_trigger_plugin.up.sql --------- Co-authored-by: Yashasvi17 <[email protected]> Co-authored-by: Prakarsh <[email protected]> Co-authored-by: Rajeev Ranjan <[email protected]> Co-authored-by: akshatsinha007 <[email protected]> Co-authored-by: Prakash <[email protected]> Co-authored-by: Vikram <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: Shashwat Dadhich <[email protected]> Co-authored-by: iamayushm <[email protected]> Co-authored-by: subhashish-devtron <[email protected]> Co-authored-by: adi6859 <[email protected]> Co-authored-by: Shivam Nagar <[email protected]> Co-authored-by: Asutosh Das <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: Nishant <[email protected]> Co-authored-by: nishant <[email protected]> Co-authored-by: Kiran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've addressed a critical issue where users could inadvertently create duplicate workflow names within an app, leading to confusion and potential errors. Additionally, users were unable to clone workflows if their names were identical, limiting workflow management flexibility. With our recent fixes, the system now prevents duplicate workflow names within an app and allows cloning workflows with identical names across different apps, enhancing usability and efficiency.
Fixes #4868
Checklist:
Does this PR introduce a user-facing change?