Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasebot global image v2 #4927

Closed
wants to merge 30 commits into from
Closed

Conversation

badal773
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Shivam-nagar23 and others added 30 commits March 13, 2024 16:57
* trim space from workflow request to ci -runner

* remove trailing and leading spaces from url on create and update material

* use strings.TrimSpace directly
* listing user and group changes

* default value chnage

* group listing optimisation

* wire_gen

* order by in group

* default values

* discard

* updated on

* case insensitive

* script number change

* specs

* review chnages

* sql update

* id for user

* script number chnage

* review comments-1

* review comments

* review comments

* rest handler remove methods

* validation for delete

* delete user handling

* review comments

* review comments

* bulk delete user and permission group

* legacy code fix from loop in query to bulk query

* export csv filters support

* Revert "export csv filters support"

This reverts commit 4448c9e.

* export csv filters

* bulk delete support with filters

* validation

* method break

* refactor the method

* condition

* open api  specs

* specs

* refactoring filters in bulk delete rolegroup

* comments

* comments

* script

* group listing

* review comments

* review comments

* review comments

* review comments

* user delete self-review

* error handling

* renaming helpers

* commets

* checks and renaming

* last login order

* script number change

* rolegroup migration

* name change

* backward compatibility handling

* self review name change

* chart-group -manager-fix

* userrolegroups

* change chnage operation

* specs update

* groups

* find by componet id

* job project id

* sql script chnage

* script number change
* extra check added for mono-repo migraiton

* comparison of repoNameWithoutPrefix and appstore name for mono repo condition

* refactor

* remove prefix

* fix

* remove-gitops-prefix-oss

* refactor

* refactor

* refactor
…ication selected. (#4820)

* merging issue resolved

* all namespace, cluster, kind remove as it is used in key

* removing unnecessary code
* bugs revert

* 4th iter code changes

* delete dag exec

* initial poc (ongoing) of handling grpc errors

* grpc error handling at install helm chart and template services

* refactoring

* refactor

* code review changes with some refactoring

* removed unused files

* refactor
* removed registerInArgo multiple impls

* extracted app metrics code

* migrated envLevel app metrics code to new service

* chore: Removed unused jira and migration  integration (#4498)

* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <[email protected]>

* chore: App store dead code cleanup and restructuring  (#4497)

* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <[email protected]>

* chart ref refactoring

* removed infra metrics db calls

* moved app metrics repositories from /internal to /pkg

* moved: const and types to bean

* removed: unused const

* review comments

* migrated some methods from chartService to chartRefService

* added dt validation service interface

* minor refactoring

* moved validation method - 1

* wip

* removed redundant appMetrics req obj

* moved app metrics bindings  to wireset

* removed multiple dead code

* remove redundant dependency

* moved ChartGroup router and rest handler to respective folder

* stage 1

* gitOps refactoring

* moved gitClient code to a common wrapper service

* chore: AppStoreDeployment Install flow refactoring

* review changes

* wip

* fix for unsupported charts

* refactoring: App Store deployment services

* minor cleanup

* renamed remote package to git

* renamed gitOpsRemoteOpService If and impl

* migrated usages of gitService to gitOperationService

* shifted git service and all gitOps clients to pkg

* gitops repository usages refactor

* refactored gitOpsRepository usages

* gitlab client creation refactoring

* renamed util/ChartService

* reverted renaming changes

* reverted renaming changes

* reverted renaming changes

* wip

* wip

* removed typo

* changes

* changes

* extracted trigger cd, nats subscriptions from wfDAGExec service

* removed gitOpsRepoName fetch logic duplicacy

* minor change for cd trigger method

* removed redundant imports

* extracted deployment bulk trigger publish event logic from workflowDag

* extracted manifest creation code from WorkflowDagExecutor

* moved WorkflowStatusUpdateHandler

* removed old refactored code

* wip - extracted k8s op method from workflowDAG part 1

* extracted artifact logic from workflowDAG

* extracted artifact logic from workflowDAG

* refactoring

* replaced slices -> k8s.io/utils/strings/slices import

* replaced slices -> k8s.io/utils/strings/slices import

* fix prod bug

* renamed PrePostStageTriggerService -> preStageTriggerService

* fix for rollback

* wip

* refactoring pre & post stage service

* updated PreCdTriggerService

* migrated AsyncTrigger consumer to eventProcessor

* review comments

* removed whitespaces

* migrated ci material topic to processor service

* migrated argo app status subsciption to common processor pkg

* migrated argo type pipeline publish and process to common pkg

* migrated appstore bulk deploy topic

* migrated cd bulk deploy topic

* migrated appstore helm install status topic

* migrated git webhook event publish

* minor changes in manifest creation service

* minor changes in cd trigger service

* minor changes in cd trigger service

* wip

* minor change in async helm install req handling

* wip

* updated common lib version(synced with main)

* safety check for concurrency in pipeline delete and asyn trigger

* updated common-lib version

* updated common-lib version to main 5807b130153800727ace993e98b24cb27b8fc1fa

---------

Co-authored-by: Nishant <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: nishant <[email protected]>
* hide ldap creds in in get req

* removed unnecessary code

* refactor

* revert

* refactor
* Branch Divergence Checker Plugin

* Delete scripts/sql/229_GitHub_branch_divergence_checker_v1.0.down.sql

* Delete assets/GitHubBranchDivergenceCheckerlogo.png

* Adding assets

* Changing asset name

* Removing asset

* Update 229_github_branch_divergence_checker.up.sql
* feat: Added Devtron CI Trigger Plugin v1.0.0

* feat: Added Apply JOB in k8s Plugin

* modified structure

* Added error handelling

* Removed CI trigger plugin

* Migration number changed

* logo changed
* Refactor ArgoUserService.go by adding a TODO

* wip

* updated API spec

* Update repo and service

* Add logging of errors

* modified API spec

* added total count in query

* updated service and rest handler layer

* Update router and resthandler

* set default req params at rest handler

* moved generics to global util

* Update resthandler

* added tracing for new queries

* fixed undefined ctx

* Update handler's rbac

* update error logs

* Update cipipeline repo

* added: comments for changes

* Change handler

* fixed typo and imports

* fixed adapter and constants

* updated test file errors and mock files

* updated API specs

* fixed API specs end points

* fixed: query errors

* fixed: linked cd condition

* fixed: typo

* fixed: search

* fixed nil check for runner query

* fixed: append in adapter

* fix searchkey to lowercase

* Fix duplicated env names

* fix pass env array as empty

* Fix error logs

* fix error

* fixed import

---------

Co-authored-by: komalreddy3 <[email protected]>
* PR plugin script

* Update 230_Github_Pull_Request_Closer.up.sql

* Update 230_Github_Pull_Request_Closer.up.sql

* Update 230_Github_Pull_Request_Closer.up.sql

* Rename 230_Github_Pull_Request_Closer.down.sql to 231_Github_Pull_Request_Closer.down.sql

* Rename 230_Github_Pull_Request_Closer.up.sql to 231_Github_Pull_Request_Closer.up.sql

* Rename GithubReleasePR.png to GithubPullRequest-Plugin-logo.png

* Update 231_Github_Pull_Request_Closer.up.sql

---------

Co-authored-by: Prakarsh <[email protected]>
* added sql

* updated event type for job in workflow request

* added comments, handling for global cm/cs

* fixed json string global cmcs

* updated global cm/cs spec

* wip

* updated sql script number

* updated sql script number
* misc: Pagerduty issue template change

Pagerduty issue template change to seek more information for validating the criticality of the issue.

* Update pager-duty.yaml

* Update pager-duty.yaml

* Update pager-duty.yaml

* feat: Adding script to calculate score for pagerduty issues (#4832)

* feat: active inactive user phase 3 (#4649)

* listing user and group changes

* default value chnage

* group listing optimisation

* wire_gen

* order by in group

* default values

* discard

* updated on

* case insensitive

* script number change

* specs

* review chnages

* sql update

* id for user

* script number chnage

* review comments-1

* review comments

* review comments

* rest handler remove methods

* validation for delete

* delete user handling

* review comments

* review comments

* bulk delete user and permission group

* legacy code fix from loop in query to bulk query

* export csv filters support

* Revert "export csv filters support"

This reverts commit 4448c9e.

* export csv filters

* bulk delete support with filters

* validation

* method break

* refactor the method

* condition

* open api  specs

* specs

* refactoring filters in bulk delete rolegroup

* comments

* comments

* script

* group listing

* review comments

* review comments

* review comments

* review comments

* user delete self-review

* error handling

* renaming helpers

* commets

* checks and renaming

* last login order

* script number change

* rolegroup migration

* name change

* backward compatibility handling

* self review name change

* chart-group -manager-fix

* userrolegroups

* change chnage operation

* specs update

* groups

* find by componet id

* job project id

* sql script chnage

* script number change

* fix: extra check added for mono-repo migraiton (#4764)

* extra check added for mono-repo migraiton

* comparison of repoNameWithoutPrefix and appstore name for mono repo condition

* refactor

* remove prefix

* fix

* remove-gitops-prefix-oss

* refactor

* refactor

* refactor

* added request method in audit logger (#4817)

* fix:  rolefilters correction with all applications and particular application selected. (#4820)

* merging issue resolved

* all namespace, cluster, kind remove as it is used in key

* removing unnecessary code

* fix: 5xx 4.0 iter (#4620)

* bugs revert

* 4th iter code changes

* delete dag exec

* initial poc (ongoing) of handling grpc errors

* grpc error handling at install helm chart and template services

* refactoring

* refactor

* code review changes with some refactoring

* removed unused files

* refactor

* chore: refactoring v4 (#4775)

* removed registerInArgo multiple impls

* extracted app metrics code

* migrated envLevel app metrics code to new service

* chore: Removed unused jira and migration  integration (#4498)

* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <[email protected]>

* chore: App store dead code cleanup and restructuring  (#4497)

* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <[email protected]>

* chart ref refactoring

* removed infra metrics db calls

* moved app metrics repositories from /internal to /pkg

* moved: const and types to bean

* removed: unused const

* review comments

* migrated some methods from chartService to chartRefService

* added dt validation service interface

* minor refactoring

* moved validation method - 1

* wip

* removed redundant appMetrics req obj

* moved app metrics bindings  to wireset

* removed multiple dead code

* remove redundant dependency

* moved ChartGroup router and rest handler to respective folder

* stage 1

* gitOps refactoring

* moved gitClient code to a common wrapper service

* chore: AppStoreDeployment Install flow refactoring

* review changes

* wip

* fix for unsupported charts

* refactoring: App Store deployment services

* minor cleanup

* renamed remote package to git

* renamed gitOpsRemoteOpService If and impl

* migrated usages of gitService to gitOperationService

* shifted git service and all gitOps clients to pkg

* gitops repository usages refactor

* refactored gitOpsRepository usages

* gitlab client creation refactoring

* renamed util/ChartService

* reverted renaming changes

* reverted renaming changes

* reverted renaming changes

* wip

* wip

* removed typo

* changes

* changes

* extracted trigger cd, nats subscriptions from wfDAGExec service

* removed gitOpsRepoName fetch logic duplicacy

* minor change for cd trigger method

* removed redundant imports

* extracted deployment bulk trigger publish event logic from workflowDag

* extracted manifest creation code from WorkflowDagExecutor

* moved WorkflowStatusUpdateHandler

* removed old refactored code

* wip - extracted k8s op method from workflowDAG part 1

* extracted artifact logic from workflowDAG

* extracted artifact logic from workflowDAG

* refactoring

* replaced slices -> k8s.io/utils/strings/slices import

* replaced slices -> k8s.io/utils/strings/slices import

* fix prod bug

* renamed PrePostStageTriggerService -> preStageTriggerService

* fix for rollback

* wip

* refactoring pre & post stage service

* updated PreCdTriggerService

* migrated AsyncTrigger consumer to eventProcessor

* review comments

* removed whitespaces

* migrated ci material topic to processor service

* migrated argo app status subsciption to common processor pkg

* migrated argo type pipeline publish and process to common pkg

* migrated appstore bulk deploy topic

* migrated cd bulk deploy topic

* migrated appstore helm install status topic

* migrated git webhook event publish

* minor changes in manifest creation service

* minor changes in cd trigger service

* minor changes in cd trigger service

* wip

* minor change in async helm install req handling

* wip

* updated common lib version(synced with main)

* safety check for concurrency in pipeline delete and asyn trigger

* updated common-lib version

* updated common-lib version to main 5807b130153800727ace993e98b24cb27b8fc1fa

---------

Co-authored-by: Nishant <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: nishant <[email protected]>

* fix: hide ldap creds in in get req (#4788)

* hide ldap creds in in get req

* removed unnecessary code

* refactor

* revert

* refactor

* pointer binding (#4826)

* Adding script to calculate score for pagerduty issues

* Update github_pagerduty_issue_score_calculation.py

* feat: Branch Divergence Checker Plugin (#4806)

* Branch Divergence Checker Plugin

* Delete scripts/sql/229_GitHub_branch_divergence_checker_v1.0.down.sql

* Delete assets/GitHubBranchDivergenceCheckerlogo.png

* Adding assets

* Changing asset name

* Removing asset

* Update 229_github_branch_divergence_checker.up.sql

* feat: Added Apply job in k8s plugin (#4828)

* feat: Added Devtron CI Trigger Plugin v1.0.0

* feat: Added Apply JOB in k8s Plugin

* modified structure

* Added error handelling

* Removed CI trigger plugin

* Migration number changed

* logo changed

* feat: Information of Linked CI Pipelines on Parent CI Pipeline (#4786)

* Refactor ArgoUserService.go by adding a TODO

* wip

* updated API spec

* Update repo and service

* Add logging of errors

* modified API spec

* added total count in query

* updated service and rest handler layer

* Update router and resthandler

* set default req params at rest handler

* moved generics to global util

* Update resthandler

* added tracing for new queries

* fixed undefined ctx

* Update handler's rbac

* update error logs

* Update cipipeline repo

* added: comments for changes

* Change handler

* fixed typo and imports

* fixed adapter and constants

* updated test file errors and mock files

* updated API specs

* fixed API specs end points

* fixed: query errors

* fixed: linked cd condition

* fixed: typo

* fixed: search

* fixed nil check for runner query

* fixed: append in adapter

* fix searchkey to lowercase

* Fix duplicated env names

* fix pass env array as empty

* Fix error logs

* fix error

* fixed import

---------

Co-authored-by: komalreddy3 <[email protected]>

* Update github_pagerduty_issue_score_calculation.py

* Update github_pagerduty_score_calculation.yml

* Update github_pagerduty_score_calculation.yml

* Update github_pagerduty_issue_score_calculation.py

* Update github_pagerduty_issue_score_calculation.py

* Update github_pagerduty_score_calculation.yml

* feat:Github Pull Request Closer (#4833)

* PR plugin script

* Update 230_Github_Pull_Request_Closer.up.sql

* Update 230_Github_Pull_Request_Closer.up.sql

* Update 230_Github_Pull_Request_Closer.up.sql

* Rename 230_Github_Pull_Request_Closer.down.sql to 231_Github_Pull_Request_Closer.down.sql

* Rename 230_Github_Pull_Request_Closer.up.sql to 231_Github_Pull_Request_Closer.up.sql

* Rename GithubReleasePR.png to GithubPullRequest-Plugin-logo.png

* Update 231_Github_Pull_Request_Closer.up.sql

---------

Co-authored-by: Prakarsh <[email protected]>

* chore: Image scanning refactoring (#4802)

* added sql

* updated event type for job in workflow request

* added comments, handling for global cm/cs

* fixed json string global cmcs

* updated global cm/cs spec

* wip

* updated sql script number

* updated sql script number

* Update github_pagerduty_score_calculation.yml

* Update github_pagerduty_issue_score_calculation.py

* Update github_pagerduty_score_calculation.yml

* Update github_pagerduty_issue_score_calculation.py

* fix: helm deployements stucked in queued for devtron apps (#4842)

* ns not found in case ips is being injected in cluster (#4844)

* Delete .github/github_pagerduty_issue_score_calculation.py

---------

Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: Raunit Verma <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: nishant <[email protected]>
Co-authored-by: Kiran <[email protected]>
Co-authored-by: komalreddy3 <[email protected]>
Co-authored-by: Prakarsh <[email protected]>

* Adding scritps to calculate score (#4848)

* Adding scritps to calculate score

* Update github_pagerduty_score_calculation.yml

---------

Co-authored-by: Prakarsh <[email protected]>

---------

Co-authored-by: Yashasvi17 <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: Raunit Verma <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: nishant <[email protected]>
Co-authored-by: Kiran <[email protected]>
Co-authored-by: komalreddy3 <[email protected]>
* Modifying pager duty python script

* Updated CODEOWNERS

---------

Co-authored-by: Prakarsh <[email protected]>
…ion _revised (#4836)

* Revised the api for handelling the overview git commits part using CiArtifact table only

* Removed unnecessary comments

* optimized the loop and intialization

* used maps instead of slices

* removed unused comments

* modified the GetUniqueArtifactIds

* Removed error from util function

* renamed the function as generateArtifactIDCommitMap
* MailMaster Plugin v1.0

* Update 232_mailmaster.up.sql

Updated Variable Names

* Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql

* Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql

* 233_mailmaster.up.sql

---------

Co-authored-by: Prakarsh <[email protected]>
* dependabot version upgrade

* dependabot version upgrade

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* argo assets deletion reverted
Copy link

gitguardian bot commented Apr 10, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret 724dfd9 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret ee355d1 charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pawan-mehta-dt pawan-mehta-dt changed the base branch from main to release-bot April 10, 2024 12:56
@pawan-mehta-dt pawan-mehta-dt changed the base branch from release-bot to main April 10, 2024 12:57
@badal773 badal773 changed the base branch from main to release-bot April 10, 2024 14:08
@badal773 badal773 closed this Apr 10, 2024
@badal773 badal773 deleted the releasebot-global-image-v2 branch April 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.