fix: review comments

dhis2 · Jan 9, 2025 · 45c9652 · 45c9652
1 parent d790496
commit 45c9652
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 11 deletions.
diff --git a/src/core_modules/capture-core/components/Widget/widgetCollapsible.types.js b/src/core_modules/capture-core/components/Widget/widgetCollapsible.types.js
@@ -2,7 +2,7 @@
 import type { Node } from 'react';
 
 export type WidgetCollapsibleProps = {|
-    header: Node,
+    header?: Node,
     children: Node,
     open: boolean,
     onOpen: () => void,

diff --git a/src/core_modules/capture-core/components/Widget/widgetNonCollapsible.types.js b/src/core_modules/capture-core/components/Widget/widgetNonCollapsible.types.js
@@ -2,7 +2,7 @@
 import type { Node } from 'react';
 
 export type WidgetNonCollapsibleProps = {|
-    header: Node,
+    header?: Node,
     children: Node,
     color?: string,
     borderless?: boolean,

diff --git a/...odules/capture-core/components/WidgetEventSchedule/ScheduleDate/ScheduleDate.component.js b/...odules/capture-core/components/WidgetEventSchedule/ScheduleDate/ScheduleDate.component.js
@@ -17,7 +17,7 @@ import { InfoBox } from '../InfoBox';
 import { baseInputStyles } from '../ScheduleOrgUnit/commonProps';
 
 
-const ScheduleDataField = withDefaultFieldContainer()(
+const ScheduleDateField = withDefaultFieldContainer()(
     withLabel({
         onGetCustomFieldLabeClass: () => labelTypeClasses.dateLabel,
     })(
@@ -57,7 +57,7 @@ const ScheduleDatePlain = ({
 }: Props) => (
     <div className={classes.fieldWrapper}>
         {!hideDueDate ?
-            <ScheduleDataField
+            <ScheduleDateField
                 label={i18n.t('Schedule date / Due date')}
                 required
                 value={scheduleDate}

diff --git a/.../capture-core/components/WidgetEventSchedule/ScheduleDate/dataEntryFieldLabels.module.css b/.../capture-core/components/WidgetEventSchedule/ScheduleDate/dataEntryFieldLabels.module.css
@@ -1,3 +1,3 @@
 .dateLabel {
     padding-top: 13px;
-}
+}
diff --git a/...pture-core/components/WidgetEventSchedule/ScheduleOrgUnit/dataEntryFieldLabels.module.css b/...pture-core/components/WidgetEventSchedule/ScheduleOrgUnit/dataEntryFieldLabels.module.css
@@ -1,3 +1,3 @@
 .dateLabel {
     padding-top: 13px;
-}
+}
diff --git a/...core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.component.js b/...core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.component.js
@@ -70,9 +70,6 @@ const WidgetEventSchedulePlain = ({
         <Widget
             noncollapsible
             borderless
-            header={
-                <></>
-            }
         >
             <div className={classes.wrapper}>
                 <DataSection

diff --git a/...core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.container.js b/...core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.container.js
@@ -188,7 +188,7 @@ export const WidgetEventSchedule = ({
             onCancel={onCancel}
             setScheduleDate={setScheduleDate}
             setScheduledOrgUnit={setScheduledOrgUnit}
-            setIsFormValid={setIsFormValid} // Viktig å beholde
+            setIsFormValid={setIsFormValid}
             onSchedule={onHandleSchedule}
             onAddNote={onAddNote}
             eventCountInOrgUnit={eventCountInOrgUnit}

diff --git a/src/core_modules/capture-core/components/WidgetEventSchedule/widgetEventSchedule.types.js b/src/core_modules/capture-core/components/WidgetEventSchedule/widgetEventSchedule.types.js
@@ -36,7 +36,11 @@ export type Props = {|
    scheduleDate?: ?string,
    serverScheduleDate?: ?string,
    suggestedScheduleDate?: ?string,
-   setScheduledOrgUnit: (orgUnit: Object) => void,
+   setScheduledOrgUnit: (orgUnit: ?{
+      id: string,
+      name: string,
+      path: string,
+  }) => void,
    setIsFormValid: (valid: boolean) => void,
    serverSuggestedScheduleDate?: ?string,
    eventCountInOrgUnit: number,