Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-18329] Add org unit selector in schedule event form #3925

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

feat: [DHIS2-18329] Add org unit selector in schedule event form #3925

wants to merge 9 commits into from
+344 −192

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Jan 2, 2025 •
edited
Loading

DHIS2-18329:

  • Implemented org. unit selector in Schedule tab
  • Modified the Infobox

@henrikmv henrikmv marked this pull request as ready for review January 2, 2025 13:14
@henrikmv henrikmv requested a review from a team as a code owner January 2, 2025 13:14
simonadomnisoru
simonadomnisoru reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @henrikmv,
Great start for this feature👏 ! I like that you used the existing folder structure from the existing DataEntries.
In addition to the code comments, I was wondering how this feature will work once DHIS2-15685 is merged. Can the user reschedule an event without having an org unit selected in ScopeSelector?
Thank you!

...e_modules/capture-core/components/WidgetEventSchedule/ScheduleDate/ScheduleDate.component.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.container.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.component.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/widgetEventSchedule.types.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-3925.capture.netlify.dhis2.org

@henrikmv henrikmv added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud and removed testing e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels Jan 9, 2025
simonadomnisoru
simonadomnisoru approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrikmv henrikmv added testing and removed testing labels Jan 15, 2025
@henrikmv henrikmv removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Jan 16, 2025
@henrikmv henrikmv marked this pull request as draft January 16, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru Awaiting requested review from simonadomnisoru

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikmv @simonadomnisoru