feat: [DHIS2-8087] Add empty launch page #3940
Open
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3940.capture.netlify.dhis2.org |
There was a problem hiding this comment.
Hi @eirikhaugstulen, to better align it with the design in the Jira ticket, I added a few comments with some minor CSS tweaks.
|
|
||
| const styles = { | ||
| incompleteMessageContainer: { | ||
| marginTop: '10px', |
There was a problem hiding this comment.
marginTop: '64px',
| infoBoxContent: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| gap: '8px', |
| display: 'flex', | ||
| flexDirection: 'column', | ||
| gap: '8px', | ||
| textAlign: 'center', |
There was a problem hiding this comment.
textAlign: 'left';
|
Hey @simonadomnisoru - sorry this PR was meant to be in draft mode 😅 I totally agree with you that the design differs a bit, the idea was that we would bridge the gap a bit between this and the other feedback box (Therefore a similar gap, marginTop and so on). However, I thought it felt a bit wrong, so wanted Joe and Karoline to have a look. I'll update once they've looked through it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: