Fix incorrect parameters going into loadObjectFromApi method.

Now works with nextProps instead of this.props in componentWillReceiveProps
dhis2 · Mar 20, 2018 · b8d1f09 · b8d1f09
1 parent f4db16c
commit b8d1f09
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/packages/sharing/src/SharingDialog.component.js b/packages/sharing/src/SharingDialog.component.js
@@ -44,7 +44,7 @@ class SharingDialog extends React.Component {
     componentDidMount() {
         this.loadDataSharingSettings();
         if (this.props.open && this.props.type && this.props.id) {
-            this.loadObjectFromApi();
+            this.loadObjectFromApi(this.props);
         }
     }
 
@@ -53,11 +53,11 @@ class SharingDialog extends React.Component {
 
         if (hasChanged('id') || hasChanged('type')) {
             this.resetState();
-            if (nextProps.open) this.loadObjectFromApi();
+            if (nextProps.open) this.loadObjectFromApi(nextProps);
         }
 
         if (!this.props.open && nextProps.open) {
-            this.loadObjectFromApi();
+            this.loadObjectFromApi(nextProps);
         }
     }
 
@@ -119,9 +119,8 @@ class SharingDialog extends React.Component {
         });
     }
 
-    loadObjectFromApi = () => {
+    loadObjectFromApi = ({ type, id }) => {
         const api = this.props.d2.Api.getApi();
-        const { type, id } = this.props;
 
         api
         .get('sharing', { type, id })