Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sharing dialog props and data table contect menu initial position #208

Conversation

HendrikThePendric
Copy link
Contributor

These are two unrelated fixes:

  1. The SharingDialog would open OK from componentDidMount, but when called from componentWillReceiveProps it would be working with the old props which were about to be replaced. Now passing the props as parameters to loadObjectFromApi and using nextProps in componentWillReceiveProps.
  2. When using React 16 and MaterialUI 0.19+ The DataTableContextMenu would initially render briefly in the top-left. Fixes with some CSS rules suggested int he issue thread [Popover] Positioning delayed mui/material-ui#8040 and Eduardo's fix in the dashboard app.

@HendrikThePendric HendrikThePendric self-assigned this Mar 20, 2018
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HendrikThePendric HendrikThePendric merged commit a997985 into master Mar 20, 2018
@varl varl deleted the fix/SharingDialog-props-and-DataTableContectMenu-initial-position branch March 20, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants