feat: persist sorting information in AO (DHIS2-14955) #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-382--dhis2-line-listing.netlify.app |
Passing run #2682 ↗︎
Details:
Review all test suite changes for PR #382 ↗︎ |
|||||||||||||||
All local state needs to be reset when loading a different AO, otherwise, because the Visualization component is not unmounted when switching AO, but simply re-renders, local state from the previous AO is kept and applied to the current AO.
edoardo
force-pushed
the
feat/save-sorting-DHIS2-14955
branch
from
1d7e613 to
3a8c98e
Compare
jenniferarnesen
removed
the
Awaiting Core Release
edoardo
force-pushed
the
feat/save-sorting-DHIS2-14955
branch
from
693df49 to
18de3f8
Compare
|
LGTM |
|
🎉 This PR is included in version 100.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14955
Fixes DHIS2-15248
Requires https://dhis2.atlassian.net/browse/DHIS2-14956
Key features
Description
Moved the sorting field and direction state from the
Visualizationcomponent to theApp.The sorting details are fetched directly in the visualization/current object, in this way the sorting is correctly applied to dashboard items too when first loaded.
One regression tho, is that changing sorting does not work in dashboard.The reason is that theonDataSortedcallback is only passed to the plugin by the LL app.The above has been fixed by adding the
onDataSortedcallback to thePluginWrappercomponent used by dashboard.TODO
Screenshots
Sorting applied and returned in the AO:
