feat: event/enrollment ui changes to prepare for TEI cross-program support (DHIS2-15454) #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-415--dhis2-line-listing.netlify.app |
janhenrikoverland
changed the title
program is an object that changes at each render triggering the fetch every time. Instead, use a memoized program.id which is the only thing needed in the fetch. Memoize also setIsListEndVisible to avoid returning a difference function from the hook.
edoardo
approved these changes
Oct 23, 2023
janhenrikoverland
approved these changes
Oct 25, 2023
dhis2-bot
added a commit
that referenced
this pull request
Oct 26, 2023
# [100.10.0](v100.9.5...v100.10.0) (2023-10-26) ### Features * event/enrollment ui changes to prepare for TEI cross-program support (DHIS2-15454) ([#415](#415)) ([53fa071](53fa071))
|
🎉 This PR is included in version 100.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15454 + DHIS2-15530
Figma
Spec
Key features
Description
The ui gone through a redesign for program, stage and dimensions selection to support more input types in the future. All the details can be found in the figma sketch and design spec (links above), but this basically means that both program/stage selection and what used to be called "main dimensions" have moved to create a better user flow.
TODO
Known issues
filteronce the backend works properly again (seeTODOinYourDimensionsPanel.js)fileMenu.cy.jstests fail because its relying on clearing stage and program (which isn't possible any more)Screenshots
TBC, pending final design review