test: add tests for error when renaming a saved visualization (DHIS2-16154) #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-455--dhis2-line-listing.netlify.app |
Passing run #2142 ↗︎
Details:
Review all test suite changes for PR #455 ↗︎ |
|||||||||||||||
jenniferarnesen
approved these changes
Nov 7, 2023
edoardo
changed the title
edoardo
force-pushed
the
fix/rename-patch-tests
branch
from
1f1c1b3 to
0ff8cd2
Compare
martinkrulltott
changed the title
janhenrikoverland
changed the title
edoardo
force-pushed
the
fix/rename-patch-tests
branch
from
8f6b636 to
bb38eb7
Compare
edoardo
force-pushed
the
fix/rename-patch-tests
branch
from
8631fee to
32c903e
Compare
edoardo
changed the title
edoardo
force-pushed
the
fix/rename-patch-tests
branch
from
9c5f3dc to
086e52a
Compare
|
🎉 This PR is included in version 100.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
edoardo
added a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-16154
Requires dhis2/analytics#1593
Key features
Description
The rename feature stopped working when support for deprecated PATCH request format was removed.
json+patchformat is required for PATCH requests now.The implementation for File Menu rename and update of custom calculations is in
analytics(see linked PR).This PR adds some tests for the File Menu rename feature.
TODO