TextInput: A couple of fixes

1. Fixes `erase`. 2. Marks some events that will handle TextInput as handled. 3. Adds Ctrl+A.
diasurgical · Oct 31, 2023 · 115c071 · 115c071
1 parent 2871895
commit 115c071
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/Source/DiabloUI/text_input.cpp b/Source/DiabloUI/text_input.cpp
@@ -33,6 +33,12 @@ bool HandleInputEvent(const SDL_Event &event, TextInputState &state,
 	case SDL_KEYDOWN: {
 		switch (event.key.keysym.sym) {
 #ifndef USE_SDL1
+		case SDLK_a:
+			if (isCtrl) {
+				state.setCursorToStart();
+				state.setSelectCursorToEnd();
+			}
+			return true;
 		case SDLK_c:
 			if (isCtrl) {
 				const std::string selectedText { state.selectedText() };
@@ -92,8 +98,11 @@ bool HandleInputEvent(const SDL_Event &event, TextInputState &state,
 			typeFn(utf8);
 			return true;
 		}
+#else
+		// Mark events that will also trigger SDL_TEXTINPUT as handled.
+		return !isCtrl && !isAlt
+		    && event.key.keysym.sym >= SDLK_SPACE && event.key.keysym.sym <= SDLK_z;
 #endif
-		return false;
 	}
 #ifndef USE_SDL1
 	case SDL_TEXTINPUT:

diff --git a/Source/DiabloUI/text_input.hpp b/Source/DiabloUI/text_input.hpp
@@ -90,7 +90,7 @@ class TextInputState {
 
 		void erase(size_t pos, size_t len)
 		{
-			std::memmove(&buf_[pos], &buf_[pos + len], len);
+			std::memmove(&buf_[pos], &buf_[pos + len], len_ - (pos + len));
 			len_ -= len;
 			buf_[len_] = '\0';
 		}