[Russian] text out of bounds in unique item stat window

[Riccila]

Feature Type

Bug

Describe

Good evening! Dear developers. There are two screenshots in the attachment. Is it possible to correct the position of the text in the description of the objects (language Russian). Specifically these, as well as possible descriptions of other unique things. Thank you in advance!

[Maderator3000]

--- EN ---

1. The name of the bug report should also be in English.
2. I fixed it in the new version of the Russian localization, losing the word "restore" to "restore." You can test it in the project builds or wait for the new version.
   I recommend closing this issue, because the problem has already been solved. If you have any questions about the Russian localization, write to me on social networks - Discord, Telegram, VKontakte. Everywhere I am @Maderator3000

UPD: with the inscription about absorbing damage from traps, I will also decide in the future.

--- RU ---

1. Название сообщения о баге тоже должно быть на английском
2. Я это пофиксил в новой версии русской локализации, утратив слово "восстановление" до "восст.". Протестировать можно в билдах проекта или ждать новую версию.

Рекомендую закрыть это issue, т.к. проблема уже решена. По любым вопросам касательно русской локализации пиши мне в соц. сети - Дискорд, Телеграм, ВКонтакте. Везде я @Maderator3000

UPD: с надписью о поглощении урона от ловушек тоже в дальнейшем порешаю.

[qndel]

@Maderator3000 we use english here
@Riccila that's not "quality of life", that's a bug

[Maderator3000]

@Maderator3000 we use english here

I know, I just see that the guy is Russian and for his convenience I answered in Russian. In short: the problem is partially solved in the updated Russian localization, which I updated. A little later I will try to fix a couple more errors related to Russian localization that I know about.

[AJenbo]

I know, I just see that the guy is Russian and for his convenience I answered in Russian.

Pretty hard for us to know to close the issue or not if we can't understand what is being said.

[Maderator3000]

Pretty hard for us to know to close the issue or not if we can't understand what is being said.

Oh, sorry. I'll take this into account in the future

[AJenbo]

UPD: I will also solve the problem with the inscription about absorbing damage from traps in the future.

Lets keep it open till this part is also solved. Thanks for handling it and the quick response.

@Riccila thank you for the nice bug report

[Maderator3000]

Got it, tomorrow after the exam (evening-night Moscow time) I'll fix the problem with the text about traps 🙃

[glebm]

A non-Russian specific issue here is that it clearly attempts to wrap the text but does so within incorrect boundaries. We should fix the boundaries passed to the text rendering function when drawing the unique item info text.

[glebm]

The info window decoration is drawn here:

devilutionX/Source/items.cpp

Line 1748 in ccbf0fc

panelX = GetRightPanel().position.x - SidePanelSize.width + 27;

The text is drawn here:

devilutionX/Source/items.cpp

Line 4090 in ccbf0fc

Rectangle rect { position + Displacement { 32, 56 }, { 257, 0 } };

The text rectangle needs to be adjusted to fit within the box.

[glebm]

The fix might be to simply return panelX on this line instead of what it's doing currently:

devilutionX/Source/items.cpp

Line 1762 in ccbf0fc

return isInStash ? leftInfoPos : rightInfoPos;

[Maderator3000]

We should fix the boundaries passed to the text rendering function when drawing the unique item info text.

Should I fix the item's stat about absorbing half of the damage from traps at the localization level or wait for code-level edits?

[AJenbo]

wait for code

[StephenCWills]

The text rectangle needs to be adjusted to fit within the box.

I'm not sure how the width of that bounding box compares to the info panel, but perhaps we should also consider allowing the text renderer to adjust character spacing.

That said, it appears the last character gets cut off? Might need to look into that as well...

EDIT: I guess if you look closely, the last character is getting wrapped and then clipped.

The text rendering logic appears to be using the width of the first line to determine the spacing for multiline text.

[Riccila]

Dear developers. Two more screenshots. As I understand it, the problem is similar. It may have already been fixed. But I decided to reset the information anyway, in case it helps.

[Riccila]

[Riccila]

[StephenCWills]

To be clear, my screenshot was taken using a fairly recent test build. The screenshots Riccila shared just now appear to have been taken in a release build, because the text is rendering out of bounds to the left. I believe that behavior may have been fixed already since I didn't see it in the test build.

My thinking is that it may be a good idea to compute text width based on the widest line rather than stopping at the first newline character.

devilutionX/Source/engine/render/text_render.cpp

Lines 513 to 514 in f7603b7

	if (next == U'\n')
	break;

[kphoenix137]

This may be a good time to implement floating info boxes for item information, perhaps as the only option. We can display only the item name in the control panel, then use a floating box with the panel/unique box information that dynamically stretches with the contents. The size limitations of the panel box and unique info box are just too restrictive and problematic, and aren't good for modding either.

[AJenbo]

Any time would be a good time for that :)

[Riccila]

Dear developers, please note one more fact - I am attaching two screenshots. On one, it seems to me, the text is scaled and everything is perfectly visible on the other, it is not. In general, if a solution to the problem is found, it will be great. If everything has already been fixed, then consider that I just signaled.

[Riccila]