CMake: Topsort object library dependencies #7637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
January 10, 2025 17:07
Pull request was converted to draft
glebm
force-pushed
the
object-libraries
branch
from
4dd193f to
a208649
Compare
Collects transitive object library dependencies in the topological order and adds cycle detection. Now transitive dependencies are actually all linked.
We still have some issues preventing even data_file_test from depending on the world: 1. `options` transitively depends on everything because of the change handlers. 2. `sound` depends on `monster` via `sgbSaveSoundOn` and `monster` depends on `sound` via `gbSoundOn`.
glebm
force-pushed
the
object-libraries
branch
from
7e0c102 to
3933201
Compare
AJenbo
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collects transitive object library dependencies in the topological order and adds cycle detection.
Now transitive dependencies are actually all linked.