Audio device settings: Fix name handling #7642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
glebm
commented
Jan 11, 2025
•
glebm
commented
- The char pointer returned by SDL is only valid temporarily, keeping it around is not allowed so we copy the string.
- Moves the trimming to DiabloUI. It now happens every frame but that's OK here (not performance-sensitive and there is little else happening on that screen).
glebm
force-pushed
the
audio-device-name
branch
from
eaebf35 to
efc959d
Compare
|
Rebased |
auto-merge was automatically disabled
January 12, 2025 15:37
Pull request was converted to draft
glebm
force-pushed
the
audio-device-name
branch
from
efc959d to
11ccdf4
Compare
1. The char pointer returned by SDL is only valid temporarily, keeping it around is not allowed so we copy the string. 2. Moves the trimming to DiabloUI. It now happens every frame but that's OK here (not performance-sensitive and there is little else happening on that screen).
glebm
force-pushed
the
audio-device-name
branch
from
11ccdf4 to
1db62ab
Compare
|
Rebased |
AJenbo
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.