Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete copy constructor in ModEntry #7653

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Delete copy constructor in ModEntry #7653

merged 1 commit into from
Jan 13, 2025

Conversation

StephenCWills
Copy link
Member

See #5437

In this case, ModEntry isn't an implementation of OptionEntryBase, but OptionEntryBoolean does take a parameter of type std::string_view and so the copy constructor for ModEntry was still pulling the rug out from under it.

@glebm glebm merged commit 8f232cf into diasurgical:master Jan 13, 2025
23 checks passed
@StephenCWills StephenCWills deleted the modlist-asan-err branch January 14, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glebm glebm glebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenCWills @glebm