-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reserved ipv6 support #332
Open
vnegi-digitalocean
wants to merge
5
commits into
digitalocean:main
Choose a base branch
from
vnegi-digitalocean:add-support-reserved-ipv6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add reserved ipv6 support #332
vnegi-digitalocean
wants to merge
5
commits into
digitalocean:main
from
vnegi-digitalocean:add-support-reserved-ipv6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnegi-digitalocean
force-pushed
the
add-support-reserved-ipv6
branch
from
January 16, 2025 05:44
ebd2476
to
fd50afc
Compare
vnegi-digitalocean
force-pushed
the
add-support-reserved-ipv6
branch
from
January 16, 2025 05:52
fd50afc
to
32ee4dd
Compare
vnegi-digitalocean
changed the title
Add reserved ipv6 support
add reserved ipv6 support
Jan 16, 2025
imaskm
reviewed
Jan 16, 2025
imaskm
reviewed
Jan 16, 2025
vnegi-digitalocean
force-pushed
the
add-support-reserved-ipv6
branch
from
January 16, 2025 07:47
d0f52c7
to
d30c69a
Compare
bentranter
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nitpicks, but overall LGTM. I'll merge after the two pieces of feedback are addressed. Nicely done!
Co-authored-by: Ben Tranter <[email protected]>
Co-authored-by: Ben Tranter <[email protected]>
Decided to merge this PR after GA available expected to be around 28th Feb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.