Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with printer data folder #46

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

speendo
Copy link

@speendo speendo commented Dec 9, 2022

These changes align the docker project's folders with the moonraker defaults (see https://moonraker.readthedocs.io/en/latest/installation/#data-folder-structure).

This should solve a couple of tickets, e.g.

Note, that I altered some directory bindings, therefore some slight changes in docker-compose.yml are necessary.

@harleckinz
Copy link

Hey speendo!

Thanks that you answered my issue!

I will test this out later. Whenever I faced with that issue I solved somehow and generated an another one as usual.

@Mx772
Copy link

Mx772 commented Jan 10, 2023

Looks like this branch fails with:

klipper     | [moonraker.py:add_warning()] - Moonraker instance running inside a container, cannot validate service file.
klipper     | [eventloop.py:_wrapper()] - Error Running Callback
klipper     | Traceback (most recent call last):
klipper     |   File "/home/klippy/moonraker/moonraker/eventloop.py", line 73, in _wrapper
klipper     |     await ret
klipper     |   File "/home/klippy/moonraker/moonraker/moonraker.py", line 175, in server_init
klipper     |     await self.start_server()
klipper     |   File "/home/klippy/moonraker/moonraker/moonraker.py", line 180, in start_server
klipper     |     await extm.start_unix_server()
klipper     |   File "/home/klippy/moonraker/moonraker/components/extensions.py", line 118, in start_unix_server
klipper     |     comms_path.mkdir()
klipper     |   File "/usr/local/lib/python3.10/pathlib.py", line 1175, in mkdir
klipper     |     self._accessor.mkdir(self, mode)
klipper     | PermissionError: [Errno 13] Permission denied: '/home/klippy/printer_data/comms'

@Mx772
Copy link

Mx772 commented Jan 10, 2023

Also results in:

klipper     | 2023-01-10 19:18:29,605 INFO success: moonraker entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
klipper     | 2023-01-10 19:18:30,607 INFO spawned: 'klipper_mcu' with pid 30
klipper     | 2023-01-10 19:18:30,606 - supervisord_dependent_startup - [INFO   ] 
klipper     | 2023-01-10 19:18:30,606 - supervisord_dependent_startup - [INFO   ] New event: Service moonraker went from STARTING to RUNNING
klipper     | 2023-01-10 19:18:30,611 - supervisord_dependent_startup - [INFO   ] Services:
klipper     | Got error -1 in sched_setscheduler: (1)Operation not permitted
klipper     | 2023-01-10 19:18:30,613 WARN exited: klipper_mcu (exit status 255; not expected)
klipper     | 2023-01-10 19:18:30,612 - supervisord_dependent_startup - [INFO   ]  - klipper           RUNNING                         dependent_startup: True 
klipper     | 2023-01-10 19:18:30,614 - supervisord_dependent_startup - [INFO   ]  - klipper_mcu       BACKOFF                         dependent_startup: True 
klipper     | 2023-01-10 19:18:30,615 - supervisord_dependent_startup - [INFO   ]  - moonraker         RUNNING                         dependent_startup: True   wait_for: 'klipper:RUNNING'
klipper     | 2023-01-10 19:18:30,616 - supervisord_dependent_startup - [INFO   ] Services not yet running (1): klipper_mcu
klipper     | RESULT 2

@sammcj
Copy link

sammcj commented Jan 11, 2023

@speendo's fork works for me and fixes the issues I had with this repo.

Note I did have to make one change and have submitted a PR to his PR (inception!) - speendo#1

@dimalo dimalo changed the base branch from main to develop January 18, 2023 16:30
@dimalo dimalo changed the base branch from develop to main January 18, 2023 16:31
@unsplorer
Copy link

Tested. This PR solved quite a few headaches. Thank you @speendo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants