-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with printer data folder #46
Open
speendo
wants to merge
6
commits into
dimalo:main
Choose a base branch
from
speendo:align-with-printer_data-folder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lipper-web-control-docker into align-with-printer_data-folder
Hey speendo! Thanks that you answered my issue! I will test this out later. Whenever I faced with that issue I solved somehow and generated an another one as usual. |
Looks like this branch fails with:
|
Also results in:
|
Tested. This PR solved quite a few headaches. Thank you @speendo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes align the docker project's folders with the moonraker defaults (see https://moonraker.readthedocs.io/en/latest/installation/#data-folder-structure).
This should solve a couple of tickets, e.g.
Note, that I altered some directory bindings, therefore some slight changes in
docker-compose.yml
are necessary.