Apply suggestions from code review

Co-authored-by: Sébastien Crozet <[email protected]>
dimforge · Nov 22, 2024 · e182d61 · e182d61
1 parent aa78d77
commit e182d61
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/src/geometry/contacts.rs b/src/geometry/contacts.rs
@@ -273,10 +273,8 @@ fn compute_contacts_for_pair_of_cells(
                         HGridEntry::BoundaryParticle(boundary_j, particle_j) => {
                             let bi = &boundaries[*boundary_i];
                             let bj = &boundaries[*boundary_j];
-                            if *boundary_i != *boundary_j {
-                                if !bi.interaction_groups.test(bj.interaction_groups) {
-                                    continue;
-                                }
+                            if *boundary_i != *boundary_j && !bi.interaction_groups.test(bj.interaction_groups) {
+                                continue;
                             }
 
                             let pi = &bi.positions[*particle_i];
@@ -353,13 +351,10 @@ fn compute_contacts_for_pair_of_cells(
                         boundaries[fluid_j].positions[particle_j]
                     } else {
                         if *fluid_i != fluid_j {
-                            let fluid_i_data = &fluids[*fluid_i];
-                            let fluid_j_data = &fluids[fluid_j];
+                            let groups_i = &fluids[*fluid_i].interaction_groups;
+                            let groups_j = &fluids[fluid_j].interaction_groups;
 
-                            if !fluid_i_data
-                                .interaction_groups
-                                .test(fluid_j_data.interaction_groups)
-                            {
+                            if !groups_i.test(groups_j) {
                                 continue;
                             }
                         }