Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with close event not firing when the search term doesn't match and ui closes #256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandeepsuvit
Copy link

@sandeepsuvit sandeepsuvit commented Jul 6, 2024

Thanks a lot for creating this awesome library.

This PR fixes the close event not triggering when the ui closes when the search term doesn't match

Here is the link to the issue that was reproduced https://stackblitz.com/edit/angular-mentions-gww2i3

  1. Close event fired when search term match is clicked and ui closes
image image
  1. Close event not firing when search term doesn't match but the ui closes
image image

The application I am building requires the close event to be handled by the parent component to set certain properties on the parent component. In the above scenario I am unable to get the close event when the search term doesn't match and the ui closes.

I have added the fix for it in the current PR. Kindly review and merge and share the updated version of the library.

This change fixes the `close` event not triggering when the ui closes when the search term doesn't match
@sandeepsuvit sandeepsuvit changed the title Update mention.directive.ts Fixes issues with close event not firing when the search term doesn't match and ui closes Jul 6, 2024
@sandeepsuvit
Copy link
Author

Hi @dmacfarlane any update on this PR? Please merge if everything is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant