Fixes issues with close event not firing when the search term doesn't match and ui closes #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for creating this awesome library.
This PR fixes the
close
event not triggering when the ui closes when the search term doesn't matchHere is the link to the issue that was reproduced https://stackblitz.com/edit/angular-mentions-gww2i3
The application I am building requires the
close
event to be handled by the parent component to set certain properties on the parent component. In the above scenario I am unable to get theclose
event when the search term doesn't match and the ui closes.I have added the fix for it in the current PR. Kindly review and merge and share the updated version of the library.