enhance Api::actionSearch #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thumb, preview) from actionList to own methods so these can be reused in other places
…new action param $basePath to be able to limit the search with subfolders as path prefix
|
should be tested with dmstr/yii2-filemanager-widgets#21 |
schmunk42
reviewed
Jan 16, 2025
| @@ -56,7 +56,7 @@ public function behaviors() | |||
| 'upload' => ['POST'], | |||
| 'resolve-permissions' => ['POST'], | |||
| 'change-permissions' => ['POST'], | |||
| 'search' => ['GET'] | |||
| 'search' => ['GET', 'POST'] | |||
There was a problem hiding this comment.
Why is POST allowed for search? It actually doesn't change anything on the server.
There was a problem hiding this comment.
Right, doesn't change anything. But using POST for such requests is valid, it would only be a problem the other way round, i.e. if we were to allow GET for non-idempotent requests.
By the way: for the list action, which also writes nothing, only POST is allowed ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhance Api::actionSearch