Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-arch support to OrientDB #4768

Closed
wants to merge 1 commit into from

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Aug 24, 2018

This PR is raised after an agreed discussion in the ticket orientechnologies/orientdb-docker#48
and the merged PR at orientechnologies/orientdb-docker#51

Please have a look and provide your guidance.

Regards,

@tianon
Copy link
Member

tianon commented Aug 24, 2018

cc @luigidellaquila

I'm looking over these, and I'm really not seeing a very compelling reason for these to be completely separate Dockerfiles -- can you elaborate on the reasoning behind that choice?

See https://github.com/docker-library/official-images#multiple-architectures for more information on our multi-architecture stance.

@tianon
Copy link
Member

tianon commented Aug 24, 2018

To clarify a bit, this is going to cause the same tag to be drastically different on different architectures, which no obvious indication of that fact for users. If there's a desire to support both ibmjava-based and alpine-based containers concurrently, I think it makes a lot more sense to make it obvious to users that's happening.

@odidev
Copy link
Contributor Author

odidev commented Aug 27, 2018

Hi @tianon

The changes are done w.r.t, to work done in ticket orientechnologies/orientdb-docker#48

However, it would be great if you can provide us with some solution to this problem, as I am aware of the fact that you are the expert in this domain 😃

Regards,

@lag-linaro
Copy link
Contributor

@tianon although your points seem to be valid and reasonable, apart from the fact that it was this PR which bought the issue to your attention, I'm not sure I see the connection between them and @odidev's submission.

IMHO @odidev has kept loyal to the current project workflow. I believe it would be more helpful for you to raise a new issue against the parent project in order to discuss them with the associated maintainers instead of discussing here.

This PR LGTM.

@tianon
Copy link
Member

tianon commented Oct 15, 2018

It's related to this PR because this is the PR which introduced multi-arch to this official image, and the method by which it has been implemented is not something we're willing to accept, regardless of how long it has been accepted in that repository (until now, it has never been part of the bits we review).

As such, I'm closing this -- we're happy to discuss and brainstorm further to help implement this in an acceptable way, but it will require upstream cooperation (@luigidellaquila) and changes to that structure in the repository.

@tianon tianon closed this Oct 15, 2018
@lag-linaro
Copy link
Contributor

The patch looked as though multi-arch was present already. I saw X86 and PPC.

However, I do understand your reasoning.

Thanks for your feedback. I'll turn my hand to it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants