Add return types on public classes and interfaces #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check why |
GromNaN
commented
Dec 15, 2023
|
Psalm baseline updated. I was confused by the fact that both psalm and phpstan are used. |
greg0ire
approved these changes
Dec 15, 2023
derrabus
reviewed
Dec 16, 2023
|
Rebase needed. |
GromNaN
force-pushed
the
return-type
branch
2 times, most recently
from
16e6238 to
ba3d6ab
Compare
GromNaN
commented
Mar 12, 2024
| @@ -14,5 +14,5 @@ interface FixtureInterface | |||
| /** | |||
| * Load data fixtures with the passed EntityManager | |||
| */ | |||
| public function load(ObjectManager $manager); | |||
| public function load(ObjectManager $manager): void; | |||
There was a problem hiding this comment.
This change can impact every project using data-fixtures. Adding the @return type annotation in the previous version will ease migration: #472
|
Can we enable this rule now? Lines 59 to 62 in 36d2078 |
GromNaN
commented
Mar 12, 2024
| @@ -56,11 +56,6 @@ | |||
| <exclude-pattern>src/*</exclude-pattern> | |||
| </rule> | |||
|
|
|||
| <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingNativeTypeHint"> | |||
There was a problem hiding this comment.
Response to #459 (comment): This rule is applied by default. This config was to exclude src dir.
There was a problem hiding this comment.
Right. I missed that you've changed the config already. 🙈
derrabus
approved these changes
Mar 12, 2024
derrabus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add return types to methods from the public API.
Follow-up #455 (review)