Fix error when use numeric for reference name #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but we should fix this on 1.8.x. |
Ok, create bew PR in that branch... #517 |
|
Closing in favor of #517 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #512
The method
ReferenceRepository::setReferenceIdentity(string $name, mixed $identity, string $class): voidtyped the parameter$namewithstringand numeric reference names is cast to integers when are recovered fromReferenceRepository::getReferenceNames($object)method in previous lines, so when pass the value of numeric name in integer with a parameter typed with string then fails.So I propose a fix to cast names to string in
ReferenceRepository::getReferenceNames($object)when are returned